From d0f38cb7cac3b04f9ba97d59ce1c04db0135ceb6 Mon Sep 17 00:00:00 2001 From: Jason Morse Date: Fri, 13 Nov 2026 00:15:22 +0000 Subject: [PATCH] fix(0.83, tests): restore macOS native test-host compilation Adapt the image portability and gzip C-linkage fixes from microsoft/react-native-macos#3095 (742d47b5728a785b455991c2b568f116e5f9dd37 and 60f09c46099b0f34c854427ba5d748b783b78fb1). Keep sanitizer policy unchanged: ASan and TSan both execute with the current toolchain. This separate prerequisite makes the renderer resize regression's existing native host buildable. Co-authored-by: Ty Rauber Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 33ea5c72-8bbd-448d-aa21-c9b99dd03c96 --- .changeset/native-test-host.md | 7 +++++++ packages/react-native/React/Base/RCTUtils.h | 6 ++++++ packages/react-native/React/Base/RCTUtils.mm | 2 +- .../rn-tester/RNTesterUnitTests/RCTGzipTests.m | 4 +--- .../RNTesterUnitTests/RCTImageLoaderTests.m | 14 ++++++++------ 5 files changed, 23 insertions(+), 10 deletions(-) create mode 100644 .changeset/native-test-host.md diff --git a/.changeset/native-test-host.md b/.changeset/native-test-host.md new file mode 100644 index 000000000000..4e4a94867945 --- /dev/null +++ b/.changeset/native-test-host.md @@ -0,0 +1,7 @@ +--- +"react-native-macos": patch +--- + + + +Restore macOS native image test compilation and gzip test linkage. diff --git a/packages/react-native/React/Base/RCTUtils.h b/packages/react-native/React/Base/RCTUtils.h index a26b1a7a5fc6..308a418c9cbf 100644 --- a/packages/react-native/React/Base/RCTUtils.h +++ b/packages/react-native/React/Base/RCTUtils.h @@ -141,6 +141,12 @@ RCT_EXTERN NSURL *RCTDataURL(NSString *mimeType, NSData *data); // Gzip functionality - compression level in range 0 - 1 (-1 for default) RCT_EXTERN NSData *__nullable RCTGzipData(NSData *__nullable data, float level); +// [macOS +// Determines whether data is already gzipped. Declared here (rather than only in +// RCTUtils.mm) so it keeps C linkage and can be called from .m unit tests. +RCT_EXTERN BOOL RCTIsGzippedData(NSData *__nullable data); +// macOS] + // Returns the relative path within the main bundle for an absolute URL // (or nil, if the URL does not specify a path within the main bundle) RCT_EXTERN NSString *__nullable RCTBundlePathForURL(NSURL *__nullable URL); diff --git a/packages/react-native/React/Base/RCTUtils.mm b/packages/react-native/React/Base/RCTUtils.mm index a378d0001e7a..6702e9ae1a6c 100644 --- a/packages/react-native/React/Base/RCTUtils.mm +++ b/packages/react-native/React/Base/RCTUtils.mm @@ -761,7 +761,7 @@ BOOL RCTForceTouchAvailable(void) [data base64EncodedStringWithOptions:(NSDataBase64EncodingOptions)0]]]; } -BOOL RCTIsGzippedData(NSData *__nullable /*data*/); // exposed for unit testing purposes +// [macOS] RCTUtils.h supplies C linkage for Objective-C callers. BOOL RCTIsGzippedData(NSData *__nullable data) { UInt8 *bytes = (UInt8 *)data.bytes; diff --git a/packages/rn-tester/RNTesterUnitTests/RCTGzipTests.m b/packages/rn-tester/RNTesterUnitTests/RCTGzipTests.m index a24d9972be77..3c13e6a3fad6 100644 --- a/packages/rn-tester/RNTesterUnitTests/RCTGzipTests.m +++ b/packages/rn-tester/RNTesterUnitTests/RCTGzipTests.m @@ -9,9 +9,7 @@ #import #import -#import - -extern BOOL RCTIsGzippedData(NSData *data); +#import // [macOS] @interface RCTNetworking (Private) diff --git a/packages/rn-tester/RNTesterUnitTests/RCTImageLoaderTests.m b/packages/rn-tester/RNTesterUnitTests/RCTImageLoaderTests.m index 6c58e9cb26d0..baedbf966369 100644 --- a/packages/rn-tester/RNTesterUnitTests/RCTImageLoaderTests.m +++ b/packages/rn-tester/RNTesterUnitTests/RCTImageLoaderTests.m @@ -7,6 +7,8 @@ #import +#import // [macOS] + #import #import @@ -35,7 +37,7 @@ - (void)setUp - (void)testImageLoading { - UIImage *image = [UIImage new]; + RCTPlatformImage *image = [RCTPlatformImage new]; // [macOS] id loader = [[RCTImageLoaderTestsURLLoader1 alloc] initWithPriority:1.0 canLoadImageURLHandler:^BOOL(__unused NSURL *requestURL) { @@ -70,7 +72,7 @@ - (void)testImageLoading XCTAssertEqual(progress, 1); XCTAssertEqual(total, 1); } - partialLoadBlock:^(UIImage *loadedImage) { + partialLoadBlock:^(RCTPlatformImage *loadedImage) { // [macOS] } completionBlock:^(NSError *loadError, id loadedImage) { XCTAssertEqualObjects(loadedImage, image); @@ -80,7 +82,7 @@ - (void)testImageLoading - (void)testImageLoaderUsesImageURLLoaderWithHighestPriority { - UIImage *image = [UIImage new]; + RCTPlatformImage *image = [RCTPlatformImage new]; // [macOS] id loader1 = [[RCTImageLoaderTestsURLLoader1 alloc] initWithPriority:1.0 canLoadImageURLHandler:^BOOL(__unused NSURL *requestURL) { @@ -130,7 +132,7 @@ - (void)testImageLoaderUsesImageURLLoaderWithHighestPriority XCTAssertEqual(progress, 1); XCTAssertEqual(total, 1); } - partialLoadBlock:^(UIImage *loadedImage) { + partialLoadBlock:^(RCTPlatformImage *loadedImage) { // [macOS] } completionBlock:^(NSError *loadError, id loadedImage) { XCTAssertEqualObjects(loadedImage, image); @@ -141,7 +143,7 @@ - (void)testImageLoaderUsesImageURLLoaderWithHighestPriority - (void)testImageDecoding { NSData *data = [NSData dataWithBytesNoCopy:blackGIF length:sizeof(blackGIF) freeWhenDone:NO]; - UIImage *image = [[UIImage alloc] initWithData:data]; + RCTPlatformImage *image = [[RCTPlatformImage alloc] initWithData:data]; // [macOS] id decoder = [[RCTImageLoaderTestsDecoder1 alloc] initWithPriority:1.0 canDecodeImageDataHandler:^BOOL(__unused NSData *imageData) { @@ -180,7 +182,7 @@ - (void)testImageDecoding - (void)testImageLoaderUsesImageDecoderWithHighestPriority { NSData *data = [NSData dataWithBytesNoCopy:blackGIF length:sizeof(blackGIF) freeWhenDone:NO]; - UIImage *image = [[UIImage alloc] initWithData:data]; + RCTPlatformImage *image = [[RCTPlatformImage alloc] initWithData:data]; // [macOS] id decoder1 = [[RCTImageLoaderTestsDecoder1 alloc] initWithPriority:1.0 canDecodeImageDataHandler:^BOOL(__unused NSData *imageData) {