fix: enforce target placement capabilities

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: e4d624ee-fa8f-49d2-8b39-0ec71fc31e84

Author: Ramakrishnan24689

common/architecture-registry.test.ts

@@ -6,8 +6,10 @@ import {
   DEFAULT_TARGET,
   SkillArchitecture,
   TARGETS,
+  buildTargetFor,
   defineArchitectures,
   enabledArchitectureLabels,
+  requireTargetPlacement,
 } from "./architecture-registry";
 import type {
   ArchitectureDefinition,
@@ -49,11 +51,28 @@ test("the manifest derives architecture validation and target availability", ()
   );
   assert.equal(DEFAULT_TARGET.architecture, "scout");
   assert.equal(DEFAULT_TARGET.kind, "skill");
+  assert.equal(
+    buildTargetFor(DEFAULT_TARGET.architecture, "automation").installTargetLabel,
+    "Scout",
+  );
 
   assert.deepEqual(enabledArchitectureLabels("skill"), ["Scout", "Cowork"]);
   assert.deepEqual(enabledArchitectureLabels("automation"), ["Scout"]);
 });
 
+test("target placements are enforced from the manifest", () => {
+  assert.equal(requireTargetPlacement("scout", "skill", "install").architecture, "scout");
+  assert.equal(requireTargetPlacement("cowork", "skill", "export").architecture, "cowork");
+  assert.throws(
+    () => requireTargetPlacement("cowork", "skill", "install"),
+    /Architecture "cowork" target "skill" does not support "install" placement/,
+  );
+  assert.throws(
+    () => requireTargetPlacement("copilot-studio", "skill", "export"),
+    /Architecture "copilot-studio" target "skill" is not enabled/,
+  );
+});
+
 test("architecture definitions reject invalid registry shapes", () => {
   const skill = {
     kind: "skill" as const,

common/architecture-registry.ts

@@ -12,6 +12,7 @@ export interface ArchitectureTargetDefinition {
   label: string;
   enabled: boolean;
   note: string;
+  /** Ordered delivery capabilities; the first entry is the primary/default placement. */
   placements: readonly TargetPlacement[];
 }
 
@@ -187,6 +188,38 @@ export const TARGETS: readonly BuildTarget[] = ARCHITECTURE_MANIFEST.flatMap(
     })),
 );
 
+export function buildTargetFor(
+  architecture: SkillArchitecture,
+  kind: BuildKind,
+): BuildTarget {
+  const target = TARGETS.find(
+    (candidate) => candidate.architecture === architecture && candidate.kind === kind,
+  );
+  if (!target) {
+    throw new Error(
+      `No "${kind}" target is configured for architecture "${architecture}".`,
+    );
+  }
+  return target;
+}
+
+export function requireTargetPlacement(
+  architecture: SkillArchitecture,
+  kind: BuildKind,
+  placement: TargetPlacement,
+): BuildTarget {
+  const target = buildTargetFor(architecture, kind);
+  if (!target.enabled) {
+    throw new Error(`Architecture "${architecture}" target "${kind}" is not enabled.`);
+  }
+  if (!target.placements.includes(placement)) {
+    throw new Error(
+      `Architecture "${architecture}" target "${kind}" does not support "${placement}" placement.`,
+    );
+  }
+  return target;
+}
+
 const defaultTarget = TARGETS.find((target) => target.enabled);
 if (!defaultTarget) {
   throw new Error("Architecture manifest must contain at least one enabled target.");

electron/skillbuilder/builder.ts

@@ -7,6 +7,7 @@ import { approveAll, type CopilotSession } from "@github/copilot-sdk";
 import {
   BuiltSkillSchema,
   renderSkillMarkdown,
+  requireTargetPlacement,
   SkillPlanSchema,
   slugifySkillName,
   toBuiltSkill,
@@ -145,6 +146,7 @@ export class SkillBuilder extends AgentBuilder<LiveBuild> {
     // proposed plan for older callers that don't pass one.
     const plan = editedPlan ? SkillPlanSchema.parse(editedPlan) : held?.lastPlan ?? null;
     if (!plan) throw new Error("There is no plan to build from yet.");
+    requireTargetPlacement(plan.architecture, "skill", target.kind);
     // The pool may have evicted the live conversation while the user edited the plan;
     // recreate one so export always works.
     if (!held) held = await this.createLive(sessionId, plan.architecture);

electron/skillbuilder/placement.test.ts

@@ -0,0 +1,20 @@
+import assert from "node:assert/strict";
+import test from "node:test";
+
+import { SkillPlanSchema } from "../../common/skill";
+import { SkillBuilder } from "./builder";
+
+test("skill creation rejects a placement unsupported by the plan architecture", async () => {
+  const builder = new SkillBuilder(() => undefined);
+  const plan = SkillPlanSchema.parse({
+    architecture: "cowork",
+    name: "reviewed-skill",
+    title: "Reviewed skill",
+    description: "A reviewed skill.",
+  });
+
+  await assert.rejects(
+    builder.create("placement-validation", plan, { kind: "install" }),
+    /Architecture "cowork" target "skill" does not support "install" placement/,
+  );
+});

package.json

@@ -14,7 +14,7 @@
     "build": "tsc --noEmit && npm run build:vite",
     "typecheck": "tsc --noEmit",
     "typecheck:evals": "tsc --noEmit -p evals/tsconfig.json",
-    "test": "node --experimental-transform-types --no-warnings --import ./evals/register.mjs --test evals/builder-imports.test.ts common/architecture-registry.test.ts electron/architectures/catalogue-registry.test.ts common/audio.test.ts common/microphone.test.ts common/narration.test.ts electron/recording-controls-bounds.test.ts electron/recording-privacy.test.ts electron/crash-guards.test.ts electron/recorder/controller.test.ts electron/recorder/session-store.test.ts electron/frames/extractor.test.ts electron/narration/audio-analysis.test.ts electron/narration/analyze-gate.test.ts electron/narration/transcribe.test.ts electron/narration/whisper.test.ts electron/sessions.test.ts electron/debug-bundle.test.ts src/skill-placement.test.ts scripts/compliance.test.mjs",
+    "test": "node --experimental-transform-types --no-warnings --import ./evals/register.mjs --test evals/builder-imports.test.ts common/architecture-registry.test.ts electron/architectures/catalogue-registry.test.ts common/audio.test.ts common/microphone.test.ts common/narration.test.ts electron/recording-controls-bounds.test.ts electron/recording-privacy.test.ts electron/crash-guards.test.ts electron/recorder/controller.test.ts electron/recorder/session-store.test.ts electron/frames/extractor.test.ts electron/narration/audio-analysis.test.ts electron/narration/analyze-gate.test.ts electron/narration/transcribe.test.ts electron/narration/whisper.test.ts electron/sessions.test.ts electron/debug-bundle.test.ts electron/skillbuilder/placement.test.ts src/skill-placement.test.ts scripts/compliance.test.mjs",
     "eval": "node --experimental-transform-types --no-warnings --import ./evals/register.mjs evals/run.ts",
     "eval:builder": "node --experimental-transform-types --no-warnings --import ./evals/register.mjs evals/builder/run.ts",
     "eval:skill": "node --experimental-transform-types --no-warnings --import ./evals/register.mjs evals/skillbuilder/run.ts",

src/Library.tsx

@@ -17,7 +17,12 @@ import type {
   SkillArchitecture,
   SkillPlan,
 } from "../common/skill";
-import { ARCHITECTURES, DEFAULT_TARGET, TARGETS } from "../common/skill";
+import {
+  ARCHITECTURES,
+  DEFAULT_TARGET,
+  TARGETS,
+  buildTargetFor,
+} from "../common/skill";
 import type { AutomationPlan, BuiltAutomation } from "../common/automation";
 import {
   DEFAULT_NARRATION_LANGUAGE,
@@ -1207,6 +1212,11 @@ function AutomationBuilderView({
   const [builtName, setBuiltName] = useState("");
   const canceled = useRef(false);
   const inFlight = useRef(false);
+  // The initial architecture can reflect a prior skill choice while a saved automation loads.
+  const automationInstallTargetLabel =
+    phase === "done"
+      ? buildTargetFor(architecture, "automation").installTargetLabel
+      : "";
 
   const updatePlan = useCallback((part: Partial<AutomationPlan>) => {
     setPlan((prev) => (prev ? { ...prev, ...part } : prev));
@@ -1399,7 +1409,9 @@ function AutomationBuilderView({
             </p>
             {exportedPath && <p className="sb-path">{exportedPath}</p>}
             <p className="sb-import-hint">
-              Import it into Scout: open Scout → Automations → Import, and choose this bundle folder.
+              Import it into {automationInstallTargetLabel}: open{" "}
+              {automationInstallTargetLabel} → Automations → Import, and choose this bundle
+              folder.
             </p>
           </div>
         )}

src/skill-placement.ts

@@ -1,4 +1,8 @@
-import { TARGETS, type BuildTarget, type SkillArchitecture } from "../common/architecture-registry";
+import {
+  buildTargetFor,
+  type BuildTarget,
+  type SkillArchitecture,
+} from "../common/architecture-registry";
 import type { SkillPlacement } from "../common/ipc";
 
 export interface SkillPlacementAction {
@@ -16,13 +20,7 @@ export interface SkillPlacementModel {
 }
 
 export function skillTargetFor(architecture: SkillArchitecture): BuildTarget {
-  const target = TARGETS.find(
-    (candidate) => candidate.kind === "skill" && candidate.architecture === architecture,
-  );
-  if (!target) {
-    throw new Error(`No skill target is configured for architecture "${architecture}".`);
-  }
-  return target;
+  return buildTargetFor(architecture, "skill");
 }
 
 export function skillPlacementModel(target: BuildTarget): SkillPlacementModel {