Skip to content

lro response generation fix - #12024

Merged
Libba Lawrence (l0lawrence) merged 1 commit into
mainfrom
lrofix
Sep 21, 2026
Merged

Libba Lawrence (l0lawrence) merged 1 commit into
mainfrom
lrofix

Conversation

@l0lawrence

@l0lawrence Libba Lawrence (l0lawrence) commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

fixes #11966, to go out with next emitter release

@microsoft-github-policy-service microsoft-github-policy-service Bot added the emitter:client:python Issue for the Python client emitter: @typespec/http-client-python label Sep 21, 2026
@pkg-pr-new

pkg-pr-new Bot commented Sep 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@typespec/http-client-python@12024

commit: 37561bb

@github-actions

Copy link
Copy Markdown
Contributor

All changed packages have been documented.

  • ✅ @typespec/http-client-python
Show changes

@typespec/http-client-python - fix ✏️

Return long-running operation response bodies when generating TypedDict-only models.

@github-actions

Copy link
Copy Markdown
Contributor

Python emitter diff

Baseline gh:8185611ef9b746984adfa0a4011d45f91731c4a1 vs this PR.

No changes to generated output.

Rendered diff: inline on the run summary, or the emitter-diff-html artifact.

Informational check (eng/emitter-diff); does not block the PR.

@azure-sdk-automation

azure-sdk-automation Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Add emitter-level coverage validating the shipped generated LRO response binding.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Medium severity

Open (1)
What changed in this PR

Fixes Python LRO response deserialization for TypedDict-only clients by ensuring response binding is generated and adding regression coverage.

Changes:

  • Updates LRO response binding generation.
  • Adds parameterized regression tests.
  • Documents the Python emitter fix.
File Summary
packages/​http-client-python/​tests/​unit/​test_lro_response.py Adds regression coverage; emitter-level generation coverage is still needed.
packages/​http-client-python/​generator/​pygen/​codegen/​serializers/​builder_serializer.py Binds the HTTP response for LRO deserialization.
.chronus/​changes/​python-lro-typeddict-response-2026-09-21.md Documents the bug fix.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/http-client-python/tests/unit/test_lro_response.py
@l0lawrence
Libba Lawrence (l0lawrence) added this pull request to the merge queue Sep 21, 2026
Merged via the queue into main with commit bcd8ff1 Sep 21, 2026
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

emitter:client:python Issue for the Python client emitter: @typespec/http-client-python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: [Python] Modeless ARM LRO callback references undefined response

3 participants