Repository navigation
lro response generation fix - #12024
Conversation
commit: |
|
All changed packages have been documented.
Show changes
|
Python emitter diffBaseline No changes to generated output. Rendered diff: inline on the run summary, or the emitter-diff-html artifact. Informational check (eng/emitter-diff); does not block the PR. |
|
You can try these changes here
|
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Add emitter-level coverage validating the shipped generated LRO response binding.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Fixes Python LRO response deserialization for TypedDict-only clients by ensuring response binding is generated and adding regression coverage.
Changes:
- Updates LRO response binding generation.
- Adds parameterized regression tests.
- Documents the Python emitter fix.
| File | Summary |
|---|---|
packages/http-client-python/tests/unit/test_lro_response.py |
Adds regression coverage; emitter-level generation coverage is still needed. |
packages/http-client-python/generator/pygen/codegen/serializers/builder_serializer.py |
Binds the HTTP response for LRO deserialization. |
.chronus/changes/python-lro-typeddict-response-2026-09-21.md |
Documents the bug fix. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

fixes #11966, to go out with next emitter release