Repository navigation
build: Restore Node engine enforcement with pnpm 11 - #12194
Merged
Timothee Guerin (timotheeguerin) merged 2 commits intoOct 16, 2026
Merged
Timothee Guerin (timotheeguerin) merged 2 commits into
Timothee Guerin (timotheeguerin) merged 2 commits into
Conversation
Contributor
|
No changes needing a change description found. |
Timothee Guerin (timotheeguerin)
marked this pull request as ready for review
October 14, 2026 23:54
Timothee Guerin (timotheeguerin)
requested review from
catalinaperalta,
iscai-msft,
Laurent Mazuel (lmazuel) and
Mark Cowlishaw (markcowl)
as code owners
October 14, 2026 23:54
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused configuration migration preserves the intended behavior with no unresolved issues.
0 open findings
What changed in this PR
Restores Node engine enforcement under pnpm 11 so incompatible dependency updates fail during installation.
Changes:
- Moves engine enforcement and update-notifier settings from
.npmrcto workspace configuration. - Replaces
manage-package-manager-versionswithpmOnFail: download.
| File | Description |
|---|---|
pnpm-workspace.yaml |
Adds pnpm 11-compatible installation settings. |
.npmrc |
Removes the migrated settings. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
You can try these changes here
|
Yuchao Yan (msyyc)
pushed a commit
to msyyc/typespec-azure
that referenced
this pull request
Oct 16, 2026
pnpm 11 ignores `engine-strict=true` in `.npmrc`, allowing dependency updates that require an unsupported Node version to pass installation. The same gap surfaced in microsoft/typespec#12188. Move the settings into `pnpm-workspace.yaml` so incompatible Node versions fail during installation again. Preserve automatic peer installation and use `pmOnFail: download` for the removed `manage-package-manager-versions` option. Companion fix: microsoft/typespec#12194. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Timothee Guerin (timotheeguerin)
enabled auto-merge
October 16, 2026 13:50
Timothee Guerin (timotheeguerin)
disabled auto-merge
October 16, 2026 16:19
Timothee Guerin (timotheeguerin)
merged commit Oct 16, 2026
0f0291e
into
microsoft:main
25 of 31 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node-incompatible dependency updates can pass CI because pnpm 11 ignores
engine-strict=truein.npmrc. This surfaced in #12188: ecmarkup now requires Node 24, but the Node 22 jobs still passed.Move the settings into
pnpm-workspace.yamlso incompatible Node versions fail during installation again. Preserve the other settings, usingpmOnFail: downloadfor the removedmanage-package-manager-versionsoption.Companion fix: Azure/typespec-azure#5717.