Repository navigation
docs(asset-emitter): Add JSDoc for builders and deferred references [skip chg] - #12221
Closed
Timothee Guerin (timotheeguerin) wants to merge 2 commits into
Closed
Timothee Guerin (timotheeguerin) wants to merge 2 commits into
Timothee Guerin (timotheeguerin) wants to merge 2 commits into
Conversation
commit: |
Contributor
|
❌ There is undocummented changes. Run The following packages have changes but are not documented.
Show changes |
Timothee Guerin (timotheeguerin)
changed the title
29 of 30 tasks
|
You can try these changes here
|
Timothee Guerin (timotheeguerin)
marked this pull request as ready for review
October 16, 2026 13:45
Timothee Guerin (timotheeguerin)
requested review from
catalinaperalta,
iscai-msft,
Laurent Mazuel (lmazuel) and
Mark Cowlishaw (markcowl)
as code owners
October 16, 2026 13:45
Contributor
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
Copilot stopped reviewing on behalf of
Timothee Guerin (timotheeguerin) due to an error
October 16, 2026 13:46
Member
Author
Timothee Guerin (timotheeguerin)
added a commit
that referenced
this pull request
Oct 16, 2026
Emitter authors currently have to read traversal internals to understand output scopes, callback lifecycles, context propagation, and deferred references. Document the complete public asset-emitter API together, including declaration naming, circular-reference handling, mutable builders, placeholder subscriptions, serialization, and writing. Existing APIs and output behavior are unchanged. Consolidates [12217](#12217), [12221](#12221). Tracked in #12228.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emitter authors composing circular output need to know when placeholders update existing values, whether callbacks replay resolved values, and how mutable builders unwrap emit results. Inheriting Array.push documentation also obscures ArrayBuilder’s argument-count return value.
Explain builder mutation and copying, placeholder subscription timing, no-emit and circular-result handling, and reference-cycle rotation and iteration. Preserve the deprecated setter guidance and inherited cycle string description without changing behavior.
Tracked in #12228.