Repository navigation
Keep Visual Studio extension dependencies current - #12296
Open
Timothee Guerin (timotheeguerin) wants to merge 2 commits into
Open
Timothee Guerin (timotheeguerin) wants to merge 2 commits into
Timothee Guerin (timotheeguerin) wants to merge 2 commits into
Conversation
microsoft-github-policy-service
Bot
added
ide
Contributor
|
All changed packages have been documented.
Show changes
|
Timothee Guerin (timotheeguerin)
added a commit
that referenced
this pull request
Oct 16, 2026
NuGet dependency updates can break PR previews when the Azure Artifacts feed has not yet saved the requested versions from upstream, as seen in #12296. PR Tools only publishes the playground, website, and VS Code extension, so it does not need to restore or build the .NET-based Visual Studio extension. Skip that work in PR Tools and correct the .NET opt-in parameter so its `false` default actually disables setup and restore. Publishing retains its restores and now runs `NuGetAuthenticate@1` first; the E2E job explicitly preserves its existing .NET setup.
|
You can try these changes here
|
Timothee Guerin (timotheeguerin)
marked this pull request as ready for review
October 16, 2026 18:00
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The Dependabot configuration does not enforce the stated exclusions for host-sensitive major upgrades.
1 open finding
What changed in this PR
Updates Visual Studio extension dependencies and adds scheduled NuGet maintenance.
Changes:
- Updates reference assemblies, VSSDK build tools, and Newtonsoft.Json within existing major versions.
- Adds weekly Dependabot checks with a seven-day cooldown.
- Records the dependency updates in Chronus.
| File | Description |
|---|---|
| packages/typespec-vs/src/Microsoft.TypeSpec.VS.csproj | Updates three NuGet dependencies. |
| .github/dependabot.yml | Adds extension-scoped weekly NuGet checks. |
| .chronus/changes/chore-vs-extension-dependency-updates-2026-9-16-11-27-6.md | Records dependency changes. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Visual Studio extension is missing routine NuGet patch updates, and its dependencies are not covered by scheduled Dependabot checks.
Bring the build tools, .NET Framework reference assemblies, and Newtonsoft.Json reference up to current patches on their existing major versions, and enable weekly NuGet updates scoped to the extension.
MessagePack 3.x and MSBuild 18.x are intentionally excluded because they need separate Visual Studio host-compatibility verification. The extension builds locally on macOS; Windows VSIX packaging and loading remain to be verified.