Repository navigation
fix: add no-config debug opt-out and isolate initialization failures #1690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
036a1ae
fix: isolate no-config debug workspace storage failures
wenytang-ms bb90ef5
fix: register no-config listeners before asynchronous setup
wenytang-ms c1353ad
Merge branch 'main' into fix/no-config-debug-storage
wenytang-ms c630614
feat: add an opt-out for no-config debugging
wenytang-ms 8281b38
Merge branch 'main' into fix/no-config-debug-storage
wenytang-ms 972b05f
Merge branch 'main' into fix/no-config-debug-storage
wenytang-ms File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT license. | ||
|
|
||
| import * as vscode from "vscode"; | ||
|
|
||
| export interface FakeCollection extends vscode.EnvironmentVariableCollection { | ||
| __calls: { replace: number; append: number; delete: number }; | ||
| } | ||
|
|
||
| export function createFakeCollection(): FakeCollection { | ||
| const store = new Map<string, vscode.EnvironmentVariableMutator>(); | ||
| const calls = { replace: 0, append: 0, delete: 0 }; | ||
| const collection: FakeCollection = { | ||
| persistent: true, | ||
| description: undefined, | ||
| get(name) { | ||
| return store.get(name); | ||
| }, | ||
| replace(name, value, options): void { | ||
| calls.replace += 1; | ||
| store.set(name, { | ||
| type: vscode.EnvironmentVariableMutatorType.Replace, | ||
| value, | ||
| options: { applyAtProcessCreation: true, applyAtShellIntegration: false, ...options }, | ||
| }); | ||
| }, | ||
| append(name, value, options): void { | ||
| calls.append += 1; | ||
| store.set(name, { | ||
| type: vscode.EnvironmentVariableMutatorType.Append, | ||
| value, | ||
| options: { applyAtProcessCreation: true, applyAtShellIntegration: false, ...options }, | ||
| }); | ||
| }, | ||
| prepend(name, value, options): void { | ||
| store.set(name, { | ||
| type: vscode.EnvironmentVariableMutatorType.Prepend, | ||
| value, | ||
| options: { applyAtProcessCreation: true, applyAtShellIntegration: false, ...options }, | ||
| }); | ||
| }, | ||
| delete(name): void { | ||
| calls.delete += 1; | ||
| store.delete(name); | ||
| }, | ||
| clear(): void { | ||
| store.clear(); | ||
| }, | ||
| forEach(callback, thisArg): void { | ||
| store.forEach((mutator, variable) => callback.call(thisArg, variable, mutator, collection)); | ||
| }, | ||
|
wenytang-ms marked this conversation as resolved.
Resolved
|
||
| *[Symbol.iterator](): IterableIterator<[string, vscode.EnvironmentVariableMutator]> { | ||
| yield* store.entries(); | ||
| }, | ||
| __calls: calls, | ||
| }; | ||
| return collection; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.