Skip to content

Commit a2662fd

Browse files
Copilotbryanchen-d
andauthored
Merge origin/main and resolve chatWidget unlockFromCodingAgent conflict
Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/f087fc87-4cbd-45a1-b76a-445fbcde48ab Co-authored-by: bryanchen-d <41454397+bryanchen-d@users.noreply.github.com>
1 parent 129524a commit a2662fd

654 files changed

Lines changed: 28369 additions & 11262 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.github/copilot-instructions.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,3 +150,4 @@ function f(x: number, y: string): void { }
150150

151151
## Learnings
152152
- Minimize the amount of assertions in tests. Prefer one snapshot-style `assert.deepStrictEqual` over multiple precise assertions, as they are much more difficult to understand and to update.
153+
- Do not stub a global object (e.g. `(mainWindow as any).ResizeObserver = ...`) or use `any` casts to install fakes in tests. Instead, make the dependency injectable: add an optional constructor parameter on the production class that defaults to the real implementation (e.g. `targetWindow.ResizeObserver`), and have the test pass a fake that implements the real interface.

‎.github/hooks/hooks.json‎

Lines changed: 0 additions & 41 deletions
This file was deleted.

‎.github/workflows/component-fixture-tests.yml‎

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,21 +28,46 @@ jobs:
2828
with:
2929
node-version-file: .nvmrc
3030

31+
- name: Prepare node_modules cache key
32+
run: mkdir -p .build && node build/azure-pipelines/common/computeNodeModulesCacheKey.ts compile $(node -p process.arch) > .build/packagelockhash
33+
34+
- name: Restore node_modules cache
35+
id: cache-node-modules
36+
uses: actions/cache@v5
37+
with:
38+
path: .build/node_modules_cache
39+
key: "node_modules-compile-${{ hashFiles('.build/packagelockhash') }}"
40+
41+
- name: Extract node_modules cache
42+
if: steps.cache-node-modules.outputs.cache-hit == 'true'
43+
run: tar -xzf .build/node_modules_cache/cache.tgz
44+
3145
- name: Install dependencies
46+
if: steps.cache-node-modules.outputs.cache-hit != 'true'
3247
run: npm ci --ignore-scripts
3348
env:
3449
ELECTRON_SKIP_BINARY_DOWNLOAD: 1
3550
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
3651
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3752

3853
- name: Install build dependencies
54+
if: steps.cache-node-modules.outputs.cache-hit != 'true'
3955
run: npm ci
4056
working-directory: build
4157

4258
- name: Install rspack dependencies
59+
if: steps.cache-node-modules.outputs.cache-hit != 'true'
4360
run: npm ci
4461
working-directory: build/rspack
4562

63+
- name: Create node_modules archive
64+
if: steps.cache-node-modules.outputs.cache-hit != 'true'
65+
run: |
66+
set -e
67+
node build/azure-pipelines/common/listNodeModules.ts .build/node_modules_list.txt
68+
mkdir -p .build/node_modules_cache
69+
tar -czf .build/node_modules_cache/cache.tgz --files-from .build/node_modules_list.txt
70+
4671
- name: Transpile source
4772
run: npm run transpile-client
4873

‎.github/workflows/screenshot-test.yml‎

Lines changed: 36 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -36,21 +36,46 @@ jobs:
3636
with:
3737
node-version-file: .nvmrc
3838

39+
- name: Prepare node_modules cache key
40+
run: mkdir -p .build && node build/azure-pipelines/common/computeNodeModulesCacheKey.ts compile $(node -p process.arch) > .build/packagelockhash
41+
42+
- name: Restore node_modules cache
43+
id: cache-node-modules
44+
uses: actions/cache@v5
45+
with:
46+
path: .build/node_modules_cache
47+
key: "node_modules-compile-${{ hashFiles('.build/packagelockhash') }}"
48+
49+
- name: Extract node_modules cache
50+
if: steps.cache-node-modules.outputs.cache-hit == 'true'
51+
run: tar -xzf .build/node_modules_cache/cache.tgz
52+
3953
- name: Install dependencies
54+
if: steps.cache-node-modules.outputs.cache-hit != 'true'
4055
run: npm ci --ignore-scripts
4156
env:
4257
ELECTRON_SKIP_BINARY_DOWNLOAD: 1
4358
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
4459
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
4560

4661
- name: Install build dependencies
62+
if: steps.cache-node-modules.outputs.cache-hit != 'true'
4763
run: npm ci
4864
working-directory: build
4965

5066
- name: Install rspack dependencies
67+
if: steps.cache-node-modules.outputs.cache-hit != 'true'
5168
run: npm ci
5269
working-directory: build/rspack
5370

71+
- name: Create node_modules archive
72+
if: steps.cache-node-modules.outputs.cache-hit != 'true'
73+
run: |
74+
set -e
75+
node build/azure-pipelines/common/listNodeModules.ts .build/node_modules_list.txt
76+
mkdir -p .build/node_modules_cache
77+
tar -czf .build/node_modules_cache/cache.tgz --files-from .build/node_modules_list.txt
78+
5479
- name: Copy codicons
5580
run: cp node_modules/@vscode/codicons/dist/codicon.ttf src/vs/base/browser/ui/codicons/codicon/codicon.ttf
5681

@@ -82,12 +107,14 @@ jobs:
82107
if (!errs.length) { console.log('No fixture errors.'); process.exit(0); }
83108
console.log(errs.length + ' fixture(s) with errors:');
84109
for (const f of errs) {
85-
const msg = f.error?.message || (typeof f.error === 'string' ? f.error : null) || 'unknown error';
110+
const errorEvents = (f.events || []).filter(e => e.isError);
111+
const msg = errorEvents.map(e => e.message).join('; ') || 'unknown error';
86112
console.log('::error::' + f.fixtureId + ': ' + msg);
87-
if (f.error?.stack) { console.log(' stack: ' + f.error.stack); }
88-
if (f.events?.length) {
89-
for (const e of f.events) { console.log(' event: ' + JSON.stringify(e)); }
113+
for (const e of errorEvents) {
114+
if (e.stack) { console.log(' stack: ' + e.stack); }
90115
}
116+
const nonErrorEvents = (f.events || []).filter(e => !e.isError);
117+
for (const e of nonErrorEvents) { console.log(' event: ' + JSON.stringify(e)); }
91118
}
92119
process.exit(1);
93120
"; then
@@ -328,11 +355,11 @@ jobs:
328355
diff -u test/componentFixtures/blocks-ci-screenshots.md /tmp/blocks-ci-updated.md || true
329356
exit 1
330357
331-
# - name: Fail if fixtures had errors
332-
# if: always() && steps.fixture_errors.outputs.has_errors == 'true'
333-
# run: |
334-
# echo "::error::One or more component fixtures failed to render. See the 'Check fixture errors' step for details."
335-
# exit 1
358+
- name: Fail if fixtures had errors
359+
if: always() && steps.fixture_errors.outputs.has_errors == 'true'
360+
run: |
361+
echo "::error::One or more component fixtures failed to render. See the 'Check fixture errors' step for details."
362+
exit 1
336363
337364
338365
# - name: Prepare explorer artifact

‎.vscode/extensions/vscode-pr-pinger/package-lock.json‎

Lines changed: 117 additions & 24 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎build/.cachesalt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2026-04-06T18:11:48.597Z
1+
2026-05-07T18:45:07.002Z

‎build/.moduleignore‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -238,3 +238,8 @@ zone.js/dist/**
238238
@github/copilot-sdk/node_modules/@github/copilot-linux-x64/**
239239
@github/copilot-sdk/node_modules/@github/copilot-win32-arm64/**
240240
@github/copilot-sdk/node_modules/@github/copilot-win32-x64/**
241+
242+
# es5-ext is quarantined protestware (sonatype-2022-2248). It is only consumed
243+
# in websocket's browser.js inside a try/catch with a globalThis fallback,
244+
# so it is unnecessary in the browsers/runtimes VS Code supports.
245+
es5-ext/**

0 commit comments

Comments
 (0)