Repository navigation
Yemohyle/response success gdpr blocks - #315128
Merged
roblourens merged 3 commits intoMay 7, 2026
Merged
roblourens merged 3 commits into
roblourens merged 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns the response.success telemetry event __GDPR__ annotations across BYOK providers so GDPR tooling recognizes the same set of possible properties regardless of which provider path emits the event.
Changes:
- Added missing
response.successGDPR properties (requestKind,conversationId,subType,modelCallId,parentRequestId,parentModelCallId,iterationNumber) to the Gemini BYOK provider annotation block. - Added the same missing
response.successGDPR properties to the Anthropic BYOK provider annotation block.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/extension/byok/vscode-node/geminiNativeProvider.ts | Extends response.success __GDPR__ block to include the missing properties for consistency with the canonical declaration. |
| extensions/copilot/src/extension/byok/vscode-node/anthropicProvider.ts | Extends response.success __GDPR__ block to include the missing properties for consistency with the canonical declaration. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
roblourens
approved these changes
May 7, 2026
roblourens
enabled auto-merge (squash)
May 7, 2026 22:35
Raymond Zhao (rzhao271)
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align
response.successGDPR annotations across BYOK providersThe
response.successtelemetry event's__GDPR__block inchatMLFetcherTelemetry.tshad properties that were missing from the BYOK provider annotations (anthropicProvider.tsandgeminiNativeProvider.ts). This PR adds the missing properties to both BYOK files so all three declarations are consistent:requestKindconversationIdsubTypemodelCallIdparentRequestIdparentModelCallIditerationNumberThis ensures the GDPR tooling correctly recognizes all properties that may be emitted on this event, regardless of which code path sends it.