Improves animated value

[Henning Dieterichs (hediet)]

No description provided.

[Ladislau Szomoru (lszomoru)]

Henning Dieterichs (@hediet), could we move this out of editor/contrib so that it can be used in other places as well? Thanks!

[Copilot]

Pull request overview

This PR refactors the inline completions animation helpers to compute animation state using a shared “now” timestamp, and updates the inline-completions fadeout decoration to query completion state via ObservableAnimatedValue rather than the raw AnimatedValue.

Changes:

• Introduces IAnimatedValue, updates AnimatedValue to accept nowMs for getValue/isFinished, and exports InterpolationFunction.
• Adds LoopingAnimatedValue and extends ObservableAnimatedValue with an isFinished(reader) helper plus consistent “now” handling.
• Updates FadeoutDecoration to call val.isFinished(reader).

Show a summary per file

File	Description
src/vs/editor/contrib/inlineCompletions/browser/model/inlineCompletionsModel.ts	Switches fadeout disposal check to use ObservableAnimatedValue.isFinished(reader).
src/vs/editor/contrib/inlineCompletions/browser/model/animation.ts	Refactors animation API to accept timestamps, adds looping animation support, and enhances ObservableAnimatedValue.

Copilot's findings

Comments suppressed due to low confidence (1)

src/vs/editor/contrib/inlineCompletions/browser/model/animation.ts:88

• ObservableAnimatedValue.const declares a return type of ObservableAnimatedValue (which defaults to ObservableAnimatedValue<IAnimatedValue>), but the constructor call infers T as AnimatedValue. Because the class has a private member depending on T, these instantiations are not assignable and this is likely to cause a TypeScript type error. Consider either (1) making the return type ObservableAnimatedValue<AnimatedValue> or (2) explicitly constructing new ObservableAnimatedValue<IAnimatedValue>(...) (or dropping the generic if you intend it to always hold IAnimatedValue).

export class ObservableAnimatedValue<T extends IAnimatedValue = IAnimatedValue> {
	public static const(value: number): ObservableAnimatedValue {
		return new ObservableAnimatedValue(AnimatedValue.const(value));
	}

• Files reviewed: 2/2 changed files
• Comments generated: 2