Repository navigation
Adds fixture for https://github.com/microsoft/vscode/issues/309796 - #315226
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new component fixture to reproduce and visually validate the Windows terminal tool-approval UI issue where backslashes can disappear in the confirmation title/path rendering.
Changes:
- Extended the chat widget fixture message schema to support passing precomputed terminal confirmation display data (
commandLine,cwdLabel,cdPrefix). - Wired
confirmationinto the terminal tool invocation fixture data so the UI can render the extractedcdprefix scenario. - Added a new fixture scenario for issue #309796 and exposed it under a new
bugsgrouping.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/test/browser/componentFixtures/chat/chatWidget.fixture.ts | Adds terminal confirmation display data support and introduces a new fixture reproducing #309796. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
+354
to
+356
| bugs: defineThemedFixtureGroup({ | ||
| 'issue-309796-missing-backslash': defineComponentFixture({ render: ctx => renderChatWidget(ctx, { messages: ISSUE_309796_MISSING_BACKSLASH }) }), | ||
| }) as unknown as ReturnType<typeof defineComponentFixture>, |
Contributor
Screenshot ChangesBase: Changed (6)
|
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/GreenElicitationInContext/Light
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/OrangeElicitationInContext/Dark
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/OrangeElicitationInContext/Light
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/RedElicitationInContext/Dark
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/RedElicitationInContext/Light
| Before | After |
|---|---|
 |
 |
Added (2)
chat/widget/chatWidget/bugs/issue-309796-missing-backslash/Dark
chat/widget/chatWidget/bugs/issue-309796-missing-backslash/Light
Christof Marti (chrmarti)
previously approved these changes
May 8, 2026
Henning Dieterichs (hediet)
force-pushed
the
hediet/b/level-sheep
branch
from
May 8, 2026 13:01
03203d8 to
d44594e
Compare
Henning Dieterichs (hediet)
disabled auto-merge
May 8, 2026 13:26
Henning Dieterichs (hediet)
enabled auto-merge (squash)
May 8, 2026 13:26
Sandeep Somavarapu (sandy081)
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds fixture for #309796