Repository navigation
Move details to hover - #315234
Merged
Merged
Move details to hover#315234
Conversation
Christof Marti (chrmarti)
enabled auto-merge (rebase)
May 8, 2026 10:58
Christof Marti (chrmarti)
force-pushed
the
chrmarti/stingy-flamingo
branch
from
May 8, 2026 11:02
4add770 to
93e2d51
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors how terminal tool-confirmation risk/disclaimer details are presented by moving the additional details into a dedicated hover on a trailing info icon within the ToolRiskBadgeWidget, keeping the confirmation UI more compact (Issue #315215).
Changes:
- Extend
ToolRiskBadgeWidgetwith a trailing info icon that shows AI-generated note + optional detail markdown via hover. - Update terminal tool confirmation rendering to move disclaimer/unsandboxed-execution details into the risk badge hover when the badge is present, falling back to inline rendering when it’s not.
- Update component fixtures to add stable screenshot coverage for the hover content via a rendered hover preview panel.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/test/browser/componentFixtures/chat/chatToolRiskBadge.fixture.ts | Adds hover-preview fixtures and updates risk scenarios for screenshot testing. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/toolRiskBadgeWidget.ts | Adds details hover support (info icon, markdown builder, hide event). |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/media/toolRiskBadge.css | Styles the new trailing details/info icon within the badge. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/chatTerminalToolConfirmationSubPart.ts | Routes disclaimer/unsandboxed details into the risk badge hover when available. |
Copilot's findings
- Files reviewed: 5/5 changed files
- Comments generated: 3
Christof Marti (chrmarti)
force-pushed
the
chrmarti/stingy-flamingo
branch
from
May 8, 2026 12:02
93e2d51 to
f8c114d
Compare
Contributor
Screenshot ChangesBase: Changed (20)
|
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/Green/Light
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/Orange/Dark
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/Orange/Light
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/Red/Dark
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/Red/Light
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/GreenInContext/Dark
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/GreenInContext/Light
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/OrangeInContext/Dark
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/OrangeInContext/Light
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/RedInContext/Dark
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/RedInContext/Light
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/GreenElicitationInContext/Dark
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/GreenElicitationInContext/Light
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/OrangeElicitationInContext/Dark
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/OrangeElicitationInContext/Light
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/RedElicitationInContext/Dark
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/RedElicitationInContext/Light
| Before | After |
|---|---|
 |
 |
chat/widget/chatWidget/PendingToolApproval/Dark
| Before | After |
|---|---|
 |
 |
chat/widget/chatWidget/PendingToolApproval/Light
| Before | After |
|---|---|
 |
 |
Added (8)
chat/chatToolRiskBadge/HoverPreviewNoDetails/Dark
chat/chatToolRiskBadge/HoverPreviewNoDetails/Light
chat/chatToolRiskBadge/HoverPreviewDisclaimer/Dark
chat/chatToolRiskBadge/HoverPreviewDisclaimer/Light
chat/chatToolRiskBadge/HoverPreviewUnsandboxed/Dark
chat/chatToolRiskBadge/HoverPreviewUnsandboxed/Light
chat/chatToolRiskBadge/HoverPreviewUnsandboxedWithDisclaimer/Dark
chat/chatToolRiskBadge/HoverPreviewUnsandboxedWithDisclaimer/Light
Removed (6)
chat/chatToolRiskBadge/RedWithDisclaimerInContext/Dark
chat/chatToolRiskBadge/RedWithDisclaimerInContext/Light
chat/chatToolRiskBadge/RedUnsandboxedInContext/Dark
chat/chatToolRiskBadge/RedUnsandboxedInContext/Light
chat/chatToolRiskBadge/RedUnsandboxedWithDisclaimerInContext/Dark
chat/chatToolRiskBadge/RedUnsandboxedWithDisclaimerInContext/Light
Christof Marti (chrmarti)
disabled auto-merge
May 8, 2026 12:09
Christof Marti (chrmarti)
force-pushed
the
chrmarti/stingy-flamingo
branch
from
May 8, 2026 12:17
f8c114d to
3ba8b17
Compare
Alex Ross (alexr00)
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#315215