Repository navigation
sessions: cover returning the only quick chat to an empty Chats section - #343025
Merged
Sandeep Somavarapu (sandy081) merged 1 commit intoOct 20, 2026
Merged
Conversation
Adds a regression test for #340740: a quick chat moved into a custom group can be dragged back onto the Chats section header even when it is the only quick chat, so Chats is empty and renders its placeholder. The drop target itself was fixed by #342591, which resolves drops to placements and lets quick chats return to Chats; its test only covered a populated Chats section. Fixes #340740 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused test-only changes preserve existing helper defaults and have no actionable findings.
No open issues 🎉
What changed in this PR
Adds regression coverage for returning the only grouped quick chat to an empty Chats section, complementing the fix in #342591 for #340740. No product code changes.
Changes:
- Extends the test helper to optionally enable quick-chat support and empty default sections.
- Adds a drag-and-drop test verifying that dropping onto the empty Chats header removes group membership.
| File | Description |
|---|---|
| src/vs/sessions/contrib/sessions/test/browser/sessionsList.test.ts | Extends the harness and adds empty-Chats regression coverage. |
Review effort: Balanced
Martin Aeschlimann (aeschli)
approved these changes
Oct 20, 2026
Sandeep Somavarapu (sandy081)
deleted the
agents/fix-agent-window-quick-chat-move
branch
October 20, 2026 21:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #340740
Adds a regression test for #340740 (Agents window: quick chats trapped in a custom group).
The behavior was fixed by #342591, which resolves session drops to placements and allows a grouped quick chat to return to the Chats section. That PR covered dropping a grouped quick chat onto a Chats section that still contains another quick chat. This PR covers the case reported in the issue: the moved quick chat is the only one, so Chats is empty and shows its "No chats" placeholder. That state requires a provider that supports quick chats and
sessions.list.showEmptyDefaultGroupsenabled, so the suite-localrenderGroupedListhelper gains an optionalsupportsQuickChatsparameter.Test-only change; no product code changes.
How to test
./scripts/test.sh --run src/vs/sessions/contrib/sessions/test/browser/sessionsList.test.ts --run src/vs/sessions/contrib/sessions/test/browser/sessionsListContextMenu.test.ts: passed (275 passing)npm run typecheck-client: passednpm run eslint -- src/vs/sessions/contrib/sessions/test/browser/sessionsList.test.tsand pre-commit hygiene: passed