Skip to content

Commit 12319bc

Browse files
committed
- adds a verification for the protocol to be over TLS before attaching the token
1 parent add6834 commit 12319bc

2 files changed

Lines changed: 19 additions & 0 deletions

File tree

‎src/main/java/com/microsoft/graph/authentication/TokenCredentialAuthProvider.java‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,8 @@ public Request authenticateRequest(@Nonnull final Request request) throws Authen
118118
private boolean ShouldAuthenticateRequest(@Nonnull final String requestUrl) {
119119
try {
120120
final URL url = new URL(requestUrl);
121+
if(!url.getProtocol().toLowerCase(Locale.ROOT).equals("https"))
122+
return false;
121123
final String hostName = url.getHost().toLowerCase(Locale.getDefault());
122124
return validGraphHostNames.contains(hostName);
123125
} catch (MalformedURLException ex) {

‎src/test/java/com/microsoft/graph/authentication/TokenCredentialAuthProviderTest.java‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,23 @@ public void TokenCredentialAuthProviderDoesNotAddTokenOnInvalidDomainsTestIAuthe
105105
Assert.assertTrue(request.getHeaders().isEmpty());
106106
authProvider.authenticateRequest(request);
107107

108+
//Assert
109+
Assert.assertTrue(request.getHeaders().isEmpty());
110+
}
111+
@Test
112+
public void TokenCredentialAuthProviderDoesNotAddTokenOnInvalidProtocols() throws AuthenticationException,
113+
MalformedURLException {
114+
115+
//Arrange
116+
final TokenCredential mockCredential = MockTokenCredential.getMockTokenCredential();
117+
final IHttpRequest request = mock(IHttpRequest.class);
118+
when(request.getRequestUrl()).thenReturn(new URL("http://graph.microsoft.com"));
119+
final TokenCredentialAuthProvider authProvider = new TokenCredentialAuthProvider(mockCredential);
120+
121+
//Act
122+
Assert.assertTrue(request.getHeaders().isEmpty());
123+
authProvider.authenticateRequest(request);
124+
108125
//Assert
109126
Assert.assertTrue(request.getHeaders().isEmpty());
110127
}

0 commit comments

Comments
 (0)