Skip to content

Commit 5a31e11

Browse files
committed
- fixes compliance issue with java bean spec
1 parent 7a7a507 commit 5a31e11

3 files changed

Lines changed: 9 additions & 5 deletions

File tree

‎src/main/java/com/microsoft/graph/httpcore/TelemetryHandler.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public Response intercept(@Nonnull final Chain chain) throws IOException {
2929
if(telemetryOptions == null)
3030
telemetryOptions = new TelemetryOptions();
3131

32-
String featureUsage = "(featureUsage=" + telemetryOptions.getFeatureUsage() + ")";
32+
String featureUsage = "(featureUsage=" + telemetryOptions.getSerializedFeatureUsage() + ")";
3333
String javaVersion = System.getProperty("java.version");
3434
String sdkversion_value = GRAPH_VERSION_PREFIX + "/" + VERSION + " " + featureUsage + " " + JAVA_VERSION_PREFIX + "/" + javaVersion;
3535
telemetryAddedBuilder.addHeader(SDK_VERSION, sdkversion_value);

‎src/main/java/com/microsoft/graph/httpcore/middlewareoption/TelemetryOptions.java‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,12 @@ public void setFeatureUsage(int flag) {
2020
featureUsage = featureUsage | flag;
2121
}
2222

23+
public int getFeatureUsage() {
24+
return featureUsage;
25+
}
26+
2327
@Nonnull
24-
public String getFeatureUsage() {
28+
public String getSerializedFeatureUsage() {
2529
return Integer.toHexString(featureUsage);
2630
}
2731

‎src/test/java/com/microsoft/graph/httpcore/TelemetryOptionsTest.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,16 @@ public void setFeatureUsageTest() {
2121
TelemetryOptions telemetryOptions = new TelemetryOptions();
2222
telemetryOptions.setFeatureUsage(TelemetryOptions.AUTH_HANDLER_ENABLED_FLAG);
2323
telemetryOptions.setFeatureUsage(TelemetryOptions.REDIRECT_HANDLER_ENABLED_FLAG);
24-
assertTrue(telemetryOptions.getFeatureUsage().compareTo("5")==0);
24+
assertTrue(telemetryOptions.getSerializedFeatureUsage().compareTo("5")==0);
2525
}
2626

2727
@Test
28-
public void getFeatureUsageTest() {
28+
public void getSerializedFeatureUsageTest() {
2929
TelemetryOptions telemetryOptions = new TelemetryOptions();
3030
telemetryOptions.setFeatureUsage(TelemetryOptions.AUTH_HANDLER_ENABLED_FLAG);
3131
telemetryOptions.setFeatureUsage(TelemetryOptions.REDIRECT_HANDLER_ENABLED_FLAG);
3232
telemetryOptions.setFeatureUsage(TelemetryOptions.RETRY_HANDLER_ENABLED_FLAG);
33-
assertTrue(telemetryOptions.getFeatureUsage().compareTo("7")==0);
33+
assertTrue(telemetryOptions.getSerializedFeatureUsage().compareTo("7")==0);
3434
}
3535

3636
@Test

0 commit comments

Comments
 (0)