Skip to content

Commit b637452

Browse files
committed
- moves the remaining of the http tests to core
1 parent 7788912 commit b637452

2 files changed

Lines changed: 322 additions & 0 deletions

File tree

Lines changed: 178 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,178 @@
1+
package com.microsoft.graph.http;
2+
3+
import static org.junit.Assert.assertEquals;
4+
import static org.junit.Assert.assertNotNull;
5+
import static org.junit.Assert.assertNull;
6+
import static org.mockito.Mockito.doAnswer;
7+
import static org.mockito.Mockito.doNothing;
8+
import static org.mockito.Mockito.mock;
9+
import static org.mockito.Mockito.when;
10+
import static org.mockito.Mockito.anyObject;
11+
12+
import java.util.ArrayList;
13+
import java.util.Arrays;
14+
import java.util.HashMap;
15+
import java.util.Map;
16+
17+
import javax.annotation.meta.When;
18+
19+
import org.junit.Before;
20+
import org.junit.Test;
21+
import org.mockito.Mockito;
22+
23+
import okhttp3.Call;
24+
import okhttp3.MediaType;
25+
import okhttp3.OkHttpClient;
26+
import okhttp3.Protocol;
27+
import okhttp3.Request;
28+
import okhttp3.Response;
29+
import okhttp3.ResponseBody;
30+
31+
import com.google.gson.JsonObject;
32+
import com.google.gson.JsonPrimitive;
33+
import com.microsoft.graph.core.IBaseClient;
34+
import com.microsoft.graph.logger.ILogger;
35+
import com.microsoft.graph.options.FunctionOption;
36+
import com.microsoft.graph.options.Option;
37+
import com.microsoft.graph.options.QueryOption;
38+
import com.microsoft.graph.serializer.ISerializer;
39+
40+
/**
41+
* Test cases for {@see BaseCollectionRequest}
42+
*/
43+
public class BaseCollectionRequestTests {
44+
45+
private IBaseClient mBaseClient;
46+
@SuppressWarnings("unchecked")
47+
private Class<ICollectionResponse<JsonObject>> jsonObjectCollectionResponseMockClass = (Class<ICollectionResponse<JsonObject>>)mock(ICollectionResponse.class).getClass();
48+
@SuppressWarnings("unchecked")
49+
private Class<BaseCollectionPage<JsonObject, BaseRequestBuilder<JsonObject>>> jsonObjectCollectionPageMockClass = (Class<BaseCollectionPage<JsonObject, BaseRequestBuilder<JsonObject>>>)mock(BaseCollectionPage.class).getClass();
50+
@SuppressWarnings("unchecked")
51+
private Class<BaseCollectionRequestBuilder<JsonObject,
52+
BaseRequestBuilder<JsonObject>,
53+
ICollectionResponse<JsonObject>,
54+
BaseCollectionPage<JsonObject, BaseRequestBuilder<JsonObject>>,
55+
BaseCollectionRequest<JsonObject, ICollectionResponse<JsonObject>, BaseCollectionPage<JsonObject, BaseRequestBuilder<JsonObject>>>>> jsonObjectCollectionRequestBuilderMockClass =
56+
(Class<BaseCollectionRequestBuilder<JsonObject,
57+
BaseRequestBuilder<JsonObject>,
58+
ICollectionResponse<JsonObject>,
59+
BaseCollectionPage<JsonObject, BaseRequestBuilder<JsonObject>>,
60+
BaseCollectionRequest<JsonObject, ICollectionResponse<JsonObject>, BaseCollectionPage<JsonObject, BaseRequestBuilder<JsonObject>>>>>)
61+
mock(BaseCollectionRequestBuilder.class).getClass();
62+
private BaseEntityCollectionRequest<JsonObject, ICollectionResponse<JsonObject>, BaseCollectionPage<JsonObject, BaseRequestBuilder<JsonObject>>> mRequest;
63+
64+
@Before
65+
public void setUp() throws Exception {
66+
mBaseClient = mock(IBaseClient.class);
67+
final Response response = new Response.Builder()
68+
.request(new Request.Builder().url("https://a.b.c").build())
69+
.protocol(Protocol.HTTP_1_1)
70+
.code(200).message("OK").body(
71+
ResponseBody.create(
72+
"[{ \"id\": \"zzz\" }]",
73+
MediaType.parse("application/json")
74+
))
75+
.addHeader("Content-Type", "application/json")
76+
.build();
77+
final OkHttpClient mockClient = BaseStreamRequestTests.getMockClient(response);
78+
final JsonObject resultobj = new JsonObject();
79+
resultobj.add("id", new JsonPrimitive("zzz"));
80+
@SuppressWarnings("unchecked")
81+
final ICollectionResponse<JsonObject> result = mock(ICollectionResponse.class);
82+
when(result.values()).thenReturn(new ArrayList<JsonObject>(Arrays.asList(resultobj)));
83+
final ISerializer mSerializer = mock(ISerializer.class);
84+
when(mSerializer.deserializeObject(anyObject(), anyObject(), anyObject())).thenReturn(result);
85+
when(mSerializer.serializeObject(anyObject())).thenReturn("[{ \"id\": \"zzz\" }]");
86+
CoreHttpProvider mProvider = new CoreHttpProvider(mSerializer,
87+
mock(ILogger.class),
88+
mockClient);
89+
when(mBaseClient.getHttpProvider()).thenReturn(mProvider);
90+
mRequest = new BaseEntityCollectionRequest<JsonObject,ICollectionResponse<JsonObject>, BaseCollectionPage<JsonObject, BaseRequestBuilder<JsonObject>>>("https://a.b.c/", mBaseClient, null, jsonObjectCollectionResponseMockClass, jsonObjectCollectionPageMockClass, jsonObjectCollectionRequestBuilderMockClass){};
91+
}
92+
93+
@Test
94+
public void testSend() {
95+
final ICollectionResponse<JsonObject> result = mRequest.send();
96+
assertNotNull(result);
97+
assertEquals("zzz", result.values().get(0).get("id").getAsString());
98+
}
99+
100+
@Test
101+
public void testPost() {
102+
final ICollectionResponse<JsonObject> result = mRequest.post(null);
103+
assertNotNull(result);
104+
assertEquals("zzz", result.values().get(0).get("id").getAsString());
105+
}
106+
107+
@SuppressWarnings("unchecked")
108+
private Class<ICollectionResponse<String>> stringCollectionResponseMockClass = (Class<ICollectionResponse<String>>)mock(ICollectionResponse.class).getClass();
109+
@SuppressWarnings("unchecked")
110+
private Class<BaseCollectionPage<String, BaseRequestBuilder<String>>> stringCollectionPageMockClass = (Class<BaseCollectionPage<String, BaseRequestBuilder<String>>>)mock(BaseCollectionPage.class).getClass();
111+
@SuppressWarnings("unchecked")
112+
private Class<BaseCollectionRequestBuilder<String,
113+
BaseRequestBuilder<String>,
114+
ICollectionResponse<String>,
115+
BaseCollectionPage<String, BaseRequestBuilder<String>>,
116+
BaseCollectionRequest<String, ICollectionResponse<String>, BaseCollectionPage<String, BaseRequestBuilder<String>>>>> stringCollectionRequestBuilderMockClass =
117+
(Class<BaseCollectionRequestBuilder<String,
118+
BaseRequestBuilder<String>,
119+
ICollectionResponse<String>,
120+
BaseCollectionPage<String, BaseRequestBuilder<String>>,
121+
BaseCollectionRequest<String, ICollectionResponse<String>, BaseCollectionPage<String, BaseRequestBuilder<String>>>>>)
122+
mock(BaseCollectionRequestBuilder.class).getClass();
123+
@Test
124+
public void testFunctionParameters() {
125+
final Option f1 = new FunctionOption("1", "one");
126+
final Option f2 = new FunctionOption("2", null);
127+
final BaseCollectionRequest<String,ICollectionResponse<String>, BaseCollectionPage<String, BaseRequestBuilder<String>>> request = new BaseCollectionRequest<String,ICollectionResponse<String>, BaseCollectionPage<String, BaseRequestBuilder<String>>>("https://a.b.c/", mock(IBaseClient.class), Arrays.asList(f1, f2), stringCollectionResponseMockClass, stringCollectionPageMockClass, stringCollectionRequestBuilderMockClass){};
128+
assertEquals("https://a.b.c/(1='one',2=null)", request.getRequestUrl().toString());
129+
request.addFunctionOption(new FunctionOption("3","two"));;
130+
assertEquals("https://a.b.c/(1='one',2=null,3='two')", request.getRequestUrl().toString());
131+
assertEquals(4, request.getOptions().size());
132+
}
133+
134+
@Test
135+
public void testQueryParameters() {
136+
final Option q1 = new QueryOption("q1","option1 ");
137+
final Option q2 = new QueryOption("q2","option2");
138+
final BaseCollectionRequest<String,ICollectionResponse<String>, BaseCollectionPage<String, BaseRequestBuilder<String>>> request = new BaseCollectionRequest<String,ICollectionResponse<String>, BaseCollectionPage<String, BaseRequestBuilder<String>>>("https://a.b.c/", mock(IBaseClient.class), Arrays.asList(q1, q2), stringCollectionResponseMockClass, stringCollectionPageMockClass, stringCollectionRequestBuilderMockClass){};
139+
assertEquals("https://a.b.c/?q1=option1%20&q2=option2", request.getRequestUrl().toString());
140+
request.addQueryOption(new QueryOption("q3","option3"));
141+
assertEquals("https://a.b.c/?q1=option1%20&q2=option2&q3=option3", request.getRequestUrl().toString());
142+
assertEquals(4,request.getOptions().size());
143+
}
144+
145+
@Test
146+
public void testFunctionAndQueryParameters() {
147+
final Option f1 = new FunctionOption("f1", "fun1");
148+
final Option f2 = new FunctionOption("f2", null);
149+
final Option q1 = new QueryOption("q1","option1 ");
150+
final Option q2 = new QueryOption("q2","option2");
151+
final BaseCollectionRequest<String,ICollectionResponse<String>, BaseCollectionPage<String, BaseRequestBuilder<String>>> request = new BaseCollectionRequest<String,ICollectionResponse<String>, BaseCollectionPage<String, BaseRequestBuilder<String>>>("https://a.b.c/", mock(IBaseClient.class), Arrays.asList(f1, f2, q1, q2), stringCollectionResponseMockClass, stringCollectionPageMockClass, stringCollectionRequestBuilderMockClass){};
152+
assertEquals("https://a.b.c/(f1='fun1',f2=null)?q1=option1%20&q2=option2", request.getRequestUrl().toString());
153+
assertEquals(5, request.getOptions().size());
154+
}
155+
156+
@Test
157+
public void testGetMethod() {
158+
assertNull(mRequest.getHttpMethod());
159+
mRequest.send();
160+
assertEquals(HttpMethod.GET, mRequest.getHttpMethod());
161+
}
162+
@Test
163+
public void testPostMethod() {
164+
assertNull(mRequest.getHttpMethod());
165+
mRequest.post(null);
166+
assertEquals(HttpMethod.POST, mRequest.getHttpMethod());
167+
}
168+
169+
@Test
170+
public void testHeader() {
171+
final String expectedHeader = "header key";
172+
final String expectedValue = "header value";
173+
final BaseCollectionRequest<String,ICollectionResponse<String>, BaseCollectionPage<String, BaseRequestBuilder<String>>> request = new BaseCollectionRequest<String,ICollectionResponse<String>, BaseCollectionPage<String, BaseRequestBuilder<String>>>("https://a.b.c/", mock(IBaseClient.class), null, stringCollectionResponseMockClass, stringCollectionPageMockClass, stringCollectionRequestBuilderMockClass){};
174+
assertEquals(1, request.getHeaders().size());
175+
request.addHeader(expectedHeader,expectedValue);
176+
assertEquals(2,request.getHeaders().size());
177+
}
178+
}
Lines changed: 144 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,144 @@
1+
package com.microsoft.graph.http;
2+
3+
import static org.junit.Assert.assertEquals;
4+
import static org.junit.Assert.assertFalse;
5+
import static org.junit.Assert.assertTrue;
6+
import static org.junit.Assert.fail;
7+
8+
import java.io.ByteArrayInputStream;
9+
import java.io.InputStream;
10+
import java.nio.charset.StandardCharsets;
11+
import java.util.Arrays;
12+
import java.util.HashMap;
13+
import java.util.Map;
14+
15+
import static org.mockito.Mockito.mock;
16+
import static org.mockito.Mockito.when;
17+
import static org.mockito.Mockito.anyObject;
18+
19+
import com.google.common.collect.ImmutableMap;
20+
import com.google.common.collect.Maps;
21+
import com.google.gson.Gson;
22+
import com.google.gson.GsonBuilder;
23+
import org.junit.Ignore;
24+
import org.junit.Test;
25+
26+
import okhttp3.OkHttpClient;
27+
28+
import com.google.gson.JsonObject;
29+
import com.google.gson.JsonPrimitive;
30+
import com.microsoft.graph.core.GraphErrorCodes;
31+
import com.microsoft.graph.logger.ILogger;
32+
import com.microsoft.graph.logger.LoggerLevel;
33+
import com.microsoft.graph.options.HeaderOption;
34+
import com.microsoft.graph.serializer.ISerializer;
35+
36+
@Ignore
37+
public class CoreHttpProviderTests {
38+
39+
private CoreHttpProvider mProvider;
40+
private Gson GSON = new GsonBuilder().create();
41+
42+
@Test
43+
public void testErrorResponse() throws Exception {
44+
final GraphErrorCodes expectedErrorCode = GraphErrorCodes.INVALID_REQUEST;
45+
final String expectedMessage = "Test error!";
46+
final GraphErrorResponse toSerialize = new GraphErrorResponse();
47+
toSerialize.error = new GraphError();
48+
toSerialize.error.code = expectedErrorCode.toString();
49+
toSerialize.error.message = expectedMessage;
50+
toSerialize.error.innererror = null;
51+
52+
setCoreHttpProvider(toSerialize);
53+
try {
54+
mProvider.send(mock(IHttpRequest.class), Object.class, null);
55+
fail("Expected exception in previous statement");
56+
} catch (final GraphServiceException e) {
57+
assertTrue(e.getMessage().indexOf("truncated") > 0);
58+
assertEquals(expectedMessage, e.getServiceError().message);
59+
}
60+
}
61+
62+
@Test
63+
public void testVerboseErrorResponse() throws Exception {
64+
final GraphErrorCodes expectedErrorCode = GraphErrorCodes.INVALID_REQUEST;
65+
final String expectedMessage = "Test error!";
66+
final GraphErrorResponse toSerialize = new GraphErrorResponse();
67+
toSerialize.error = new GraphError();
68+
toSerialize.error.code = expectedErrorCode.toString();
69+
toSerialize.error.message = expectedMessage;
70+
toSerialize.error.innererror = null;
71+
final JsonObject raw = new JsonObject();
72+
raw.add("response", new JsonPrimitive("The raw request was invalid"));
73+
toSerialize.rawObject = raw;
74+
75+
final ILogger logger = mock(ILogger.class);
76+
logger.setLoggingLevel(LoggerLevel.DEBUG);
77+
final ISerializer serializer = mock(ISerializer.class);
78+
when(serializer.deserializeObject(anyObject(), anyObject())).thenReturn(toSerialize);
79+
80+
mProvider = new CoreHttpProvider(serializer,
81+
logger,
82+
new OkHttpClient.Builder().build());
83+
84+
try {
85+
mProvider.send(mock(IHttpRequest.class), Object.class, null);
86+
fail("Expected exception in previous statement");
87+
} catch (final GraphServiceException e) {
88+
assertFalse(e.getMessage().indexOf("truncated") > 0);
89+
assertTrue(e.getMessage().indexOf("The raw request was invalid") > 0);
90+
}
91+
}
92+
93+
@Test
94+
public void testHasHeaderReturnsTrue() {
95+
HeaderOption h = new HeaderOption("name", "value");
96+
assertTrue(CoreHttpProvider.hasHeader(Arrays.asList(h), "name"));
97+
}
98+
99+
@Test
100+
public void testHasHeaderReturnsTrueWhenDifferentCase() {
101+
HeaderOption h = new HeaderOption("name", "value");
102+
assertTrue(CoreHttpProvider.hasHeader(Arrays.asList(h), "NAME"));
103+
}
104+
105+
@Test
106+
public void testHasHeaderReturnsFalse() {
107+
HeaderOption h = new HeaderOption("name", "value");
108+
assertFalse(CoreHttpProvider.hasHeader(Arrays.asList(h), "blah"));
109+
}
110+
111+
@Test
112+
public void testStreamToStringReturnsData() {
113+
String data = GSON.toJson(Maps.newHashMap(
114+
ImmutableMap.<String, String>builder()
115+
.put("key", "value")
116+
.build()));
117+
final InputStream inputStream = new ByteArrayInputStream(data.getBytes(StandardCharsets.UTF_8));
118+
119+
String convertedData = CoreHttpProvider.streamToString(inputStream);
120+
assertEquals(data, convertedData);
121+
}
122+
123+
@Test
124+
public void testStreamToStringReturnsEmpty() {
125+
final InputStream inputStream = new ByteArrayInputStream(new byte[0]);
126+
127+
String convertedData = CoreHttpProvider.streamToString(inputStream);
128+
assertEquals("", convertedData);
129+
}
130+
131+
132+
/**
133+
* Configures the http provider for test cases
134+
* @param toSerialize The object to serialize
135+
*/
136+
private void setCoreHttpProvider(final Object toSerialize) {
137+
final ISerializer serializer = mock(ISerializer.class);
138+
when(serializer.deserializeObject(anyObject(), anyObject())).thenReturn(toSerialize);
139+
mProvider = new CoreHttpProvider(serializer,
140+
mock(ILogger.class),
141+
new OkHttpClient.Builder().build());
142+
}
143+
144+
}

0 commit comments

Comments
 (0)