Skip to content

perf(router): add a __proto__ param with a computed key, not defineProperty #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dinwwwh merged 1 commit into from
Oct 29, 2026
Merged

perf(router): add a __proto__ param with a computed key, not defineProperty #194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions packages/router/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,8 +638,10 @@ function matchesSegment(expected: string | undefined, segment: string): boolean
return expected === undefined ? segment !== '' : segment === expected
}

// `params` is spread only for a param named `__proto__`, not on every pass.
/* oxlint-disable oxc/no-accumulating-spread */
function toParams<T>(route: Route<T>, segments: readonly string[]): Record<string, string> {
const params: Record<string, string> = {}
let params: Record<string, string> = {}
const end = segments.length - route.tail

for (const { name, index, catchAll } of route.params!) {
Expand All @@ -652,18 +654,15 @@ function toParams<T>(route: Route<T>, segments: readonly string[]): Record<strin
}
}

// Assigning `__proto__` would set the prototype instead of adding a key.
// Assigning `__proto__` would set the prototype, where a computed key in
// an object literal adds it.
if (name === '__proto__') {
Object.defineProperty(params, name, {
configurable: true,
enumerable: true,
value,
writable: true,
})
params = { ...params, [name]: value }
} else {
params[name] = value
}
}

return params
}
/* oxlint-enable oxc/no-accumulating-spread */
Loading