Skip to content

refactor(router): lower the shared-parts count once per braced part #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dinwwwh merged 1 commit into from
Oct 29, 2026
Merged

refactor(router): lower the shared-parts count once per braced part #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions packages/router/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,8 +371,8 @@ function indexStatics<T>(routes: MethodRoutes<T>): void {
function expand<T>(node: Node<T>, pending: unknown[], start: number, whole: boolean): void {
node.pending = undefined
// The parts of the previous route, how many of them come before its first
// param or wait, and the node after each of those, so that the next route
// skips parsing the parts it shares with them.
// part starting with `{` once decoded, and the node after each of those, so
// that the next route skips parsing the parts it shares with them.
let shared: string[] = []
let literals = 0
const nodes: Node<T>[] = [node]
Expand All @@ -399,10 +399,10 @@ function expand<T>(node: Node<T>, pending: unknown[], start: number, whole: bool
// which keeps the first of two that read the same. A route added whole
// goes after the routes waiting there.
if (segment[0] === '{') {
if (index < literals) {
literals = index
}
if (!whole && index > start) {
if (index < literals) {
literals = index
}
;(child.pending ??= []).push(parts, data, params)
continue next
}
Expand All @@ -418,9 +418,6 @@ function expand<T>(node: Node<T>, pending: unknown[], start: number, whole: bool
continue
}

if (index < literals) {
literals = index
}
// An array literal holds just its items, where a push to `[]` reserves 17.
if (params === undefined) {
params = [segment]
Expand Down
Loading