Merge pull request #699 from THEAbhishekjoshi/fix/draft-pr-lead-time

fix(analytics): include draft PR duration in commit to open segment

Author: dhruvagarwal

backend/analytics_server/mhq/service/code/sync/etl_code_analytics.py

@@ -50,7 +50,10 @@ def create_pr_metrics(
         if pr_commits:
             pr.rework_cycles = self.get_rework_cycles(pr, non_bot_pr_events, pr_commits)
             pr_commits.sort(key=lambda x: x.created_at)
-            first_commit_to_open = pr.created_at - pr_commits[0].created_at
+            first_commit_to_open = (
+                pr_performance.pull_request_ready_for_review_time
+                - pr_commits[0].created_at
+            )
             if isinstance(first_commit_to_open, timedelta):
                 pr.first_commit_to_open = first_commit_to_open.total_seconds()
 
@@ -134,6 +137,7 @@ def get_pr_performance(pr: PullRequest, pr_events: [PullRequestEvent]):
                 if first_response_end_time
                 else -1
             ),
+            pull_request_ready_for_review_time=pull_request_ready_for_review_time,
             rework_time=rework_time,
             merge_time=merge_time,
             cycle_time=cycle_time if pr.state == PullRequestState.MERGED else -1,

backend/analytics_server/mhq/service/code/sync/models.py

@@ -5,6 +5,7 @@
 class PRPerformance:
     first_commit_to_open: int = -1
     first_review_time: int = -1
+    pull_request_ready_for_review_time: int = -1
     rework_time: int = -1
     merge_time: int = -1
     merge_to_deploy: int = -1

backend/analytics_server/tests/service/code/sync/test_etl_code_analytics.py

@@ -751,3 +751,28 @@ def test_cycle_time_ready_for_review_with_draft_pr_workflow():
 
     assert performance.cycle_time == 86400
     assert performance.first_review_time == 14400
+
+
+def test_create_pr_metrics_calculates_first_commit_to_open_using_ready_for_review():
+    """Test that first_commit_to_open correctly accounts for the draft PR window."""
+    pr_service = CodeETLAnalyticsService()
+    t1 = time_now()  # commit time
+    t2 = t1 + timedelta(hours=20)  # pr created
+    t3 = t2 + timedelta(
+        hours=2
+    )  # sat in draft for 2 hours (ready_for_review event time)
+
+    pr = get_pull_request(state=PullRequestState.MERGED, created_at=t2, updated_at=t3)
+    commit = get_pull_request_commit(pr_id=pr.id, created_at=t1)
+
+    ready_for_review_event = get_pull_request_event(
+        pull_request_id=pr.id,
+        type=PullRequestEventType.READY_FOR_REVIEW.value,
+        created_at=t3,
+    )
+
+    updated_pr = pr_service.create_pr_metrics(pr, [ready_for_review_event], [commit])
+
+    expected_seconds = (t3 - t1).total_seconds()
+
+    assert updated_pr.first_commit_to_open == expected_seconds