build(deps): bump @midnight-ntwrk/wallet-sdk-facade from 3.0.0 to 4.0.1 - #457
Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
added
the
dependencies
39530f0 to
28c3af3
Compare
patextreme
left a comment
patextreme
left a comment
There was a problem hiding this comment.
Lockfile-only dependabot bump of root dependency @midnight-ntwrk/wallet-sdk-facade from ^3.0.0 to ^4.0.1 (package.json 1 line + pnpm-lock.yaml +254/−4). Reviewed at pinned head 28c3af3: no source file in the repository imports wallet-sdk-facade (repo-wide search finds only the root manifest and lockfile), so the bump has no compile-time surface here. The lockfile is internally consistent: the root importer maps ^4.0.1 to 4.0.1(ws@8.21.1), every newly added resolution (facade 4.0.1 subtree: capabilities 3.3.1, dust-wallet 4.1.0, indexer-client 1.2.2, node-client 1.1.2, prover-client 1.2.2, runtime 1.0.4, shielded 3.0.1, unshielded-wallet 3.1.0, utilities 1.2.1, address-format 3.1.2, plus @effect/platform 0.96.3, graphql-http 1.23.0, graphql-ws 6.2.1, msgpackr 1.12.1, multipasta 0.2.8, @scure/base 2.3.0, bn.js 5.2.5) carries an integrity hash and a matching snapshot, and all peer dependencies resolve in-tree (effect 3.22.1, graphql 16.14.2, ws 8.21.1). @midnight-ntwrk/midnight-did-api@0.5.0, pinned exactly at root and in standalone-environment, keeps resolving its own facade 3.0.0 instance, so the old and new wallet-sdk subtrees coexist under normal pnpm isolation. All new packages are current mainstream releases with no downgrades and no script, patch, or override changes. One non-blocking observation recorded as finding facade-dual-instance-root-vs-did-api: the diff introduces two coexisting facade major versions; harmless today because nothing imports the root facade, but worth aligning when midnight-did-api is next upgraded. No admissible blocker; approving.
| "@midnight-ntwrk/wallet-sdk-address-format": "^3.0.0", | ||
| "@midnight-ntwrk/wallet-sdk-dust-wallet": "^3.0.0", | ||
| "@midnight-ntwrk/wallet-sdk-facade": "^3.0.0", | ||
| "@midnight-ntwrk/wallet-sdk-facade": "^4.0.1", |
There was a problem hiding this comment.
Non-blocking observation: bumping the root facade to ^4.0.1 while @midnight-ntwrk/midnight-did-api@0.5.0 still resolves facade 3.0.0 leaves two wallet-sdk-facade major versions in the tree (with divergent shielded/dust-wallet/unshielded-wallet subtrees). Nothing in this repo imports the root facade, so there is no breakage today; the split only matters if future code passes wallet objects between root-level facade imports and midnight-did-api internals (instance/identity mismatches). Consider aligning both to the same major when midnight-did-api is upgraded.
|
Blocking compatibility issue: midnightntwrk/midnight-did#441 Keep this PR unmerged until the Midnight DID wallet SDK matrix is upgraded and the current-head |
yshyn-iohk
added
the
blocked
|
@dependabot recreate |
2227ab3 to
3d3984f
Compare
|
@dependabot rebase |
3d3984f to
38fbc3a
Compare
|
@dependabot rebase |
4a705b3 to
366755a
Compare
Bumps [@midnight-ntwrk/wallet-sdk-facade](https://github.com/midnight-ntwrk/artifacts) from 3.0.0 to 4.0.1. - [Commits](https://github.com/midnight-ntwrk/artifacts/commits) --- updated-dependencies: - dependency-name: "@midnight-ntwrk/wallet-sdk-facade" dependency-version: 4.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
366755a to
23767b6
Compare
2 participants
Bumps @midnight-ntwrk/wallet-sdk-facade from 3.0.0 to 4.0.1.
Commits