Send pvol metadata on mute - #1902
Merged
Merged
Conversation
Owner
|
Thanks for this, and it looks like a good idea. One little thing is that we have managed to avoid using unfortunately, I am away from machines until around October 8, so can’t test extensively until then. But certainly, IMHO the concept is good. |
mill1000
marked this pull request as ready for review
October 10, 2024 03:18
Author
|
Gave this a quick test and it seems to work as expected. |
Owner
|
Many thanks -- let's give it a try. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We discussed the possibility of sending mute state via MQTT a while ago here #1646
It seems the path of least resistance is to emit the same volume messages with the special muted volume value of
-144.0.This is in order to support implementing mute support in a Home Assistant custom integration: parautenbach/hass-shairport-sync#14
Leaving as a draft as I have yet to fully test.