Repository navigation
nut-driver/: this repo is the driver's source of truth - #14
Merged
Merged
Conversation
sigennut, not any fork or PR branch, is where the driver is actually developed and versioned. A fork (miklosbagi/nut) becomes a periodic export target purely for proposing it upstream -- this repo's own build never depends on that fork existing or that PR being accepted, rejected, or ever resolved. Worst case, this stays a permanently maintained 'NUT plus this one driver' image regardless of what upstream decides. Also, while updating nut-driver/sigenergy_modbus.c for the move: - Fixed relative-path references to private sibling repos (../../nut-sigenergy, ../../sigennut) in the header comment -- those don't exist for anyone else cloning this, and leaked private planning doc names into what's meant to be a self-contained public file. - Switched the copyright/author email to mb_nutdco@mbag.at, the NUT-submission-specific contact (distinct from mb_sigennut@mbag.at, which stays scoped to this Docker image's own artifacts). - Validated the low_battery_soc -x override before strtod() -- a typo'd value silently became a 0.0 threshold (LB would never trigger) with no error logged. - Reformatted with to actually match NUT's own recommended house style byte-for-byte (verified idempotent), now enforced by a new nut-driver-style CI job. Verified: driver still builds warning-free, full docker-compose smoke test still passes with real captured data after all of the above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
indent -kr -i8 -T FILE -l1000 -nhnlto actually match byte-for-byte, and added a new nut-driver-style CI job enforcing it going forward.Test plan