Repository navigation
AGENTS.md: when a test earns its place - #46
Merged
Merged
Conversation
A test that only re-asserts the schema, the test's config, or a code path another test already covers adds upkeep without adding proof.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the rules behind the test pruning in #43: a test proves something no other test does, doesn't re-test what a JSON Schema enforces, doesn't repeat a covered code path, and doesn't assert what its own config makes true. Adds a definition-of-done row for new or changed tests.
The
test-reviewskill and its Stop hook that enforce this will come from a dev plugin in structured-context.