Repository navigation
Enable the sctx-dev contributor plugin and its review check - #47
Merged
Merged
Conversation
mindsocket
commented
Nov 18, 2026
| bun run build # the library, then the navigator | ||
| ``` | ||
|
|
||
| The Stop hook and pre-push block while the branch adds docs, code comments or tests that the `doc-review` or `test-review` skill has not seen. Both come from structured-context's [contributor plugin](https://github.com/mindsocket/structured-context/blob/main/docs/architecture.md#contributor-plugin), which `.claude/settings.json` enables. |
Owner
Author
There was a problem hiding this comment.
This seems unnecessary. If it's necessary the hook and pre-push should instead say more until it's self explanatory. Assume agents will know what to do, don't point at docs or point out details that aren't actionable, important and non-obvious
mindsocket
marked this pull request as ready for review
November 18, 2026 12:05
The plugin from structured-context's marketplace brings the doc-review and test-review skills and a Stop hook that blocks while the branch adds docs, code comments or tests no review has seen. Pre-push runs the same check when the plugin is installed and skips it with a note otherwise. .gitattributes marks the generated bundled-definitions.ts so the check leaves it out.
mindsocket
force-pushed
the
sctx-dev-review
branch
from
November 18, 2026 12:07
f6f1d35 to
abc23c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables structured-context's
sctx-devcontributor plugin in this repo (mindsocket/structured-context#242). It brings thedoc-reviewandtest-reviewskills and a Stop hook that blocks while the branch adds docs, code comments or tests that no review has seen..claude/settings.jsonadds the structured-context marketplace and enablessctx-dev@structured-context.lefthook.ymlpre-push runs the plugin'sreview-check.shfrom the installed marketplace when it is present, and otherwise printsreview-check: sctx-dev plugin not installed, skippingand passes..gitattributesmarkspackages/map-views/src/node/bundled-definitions.tsaslinguist-generated, so the check leaves it out (it also collapses in GitHub diffs).AGENTS.mdsays what the hook and pre-push check and where they come from.Until mindsocket/structured-context#242 merges, the marketplace has no
sctx-dev, so pre-push skips the check and the AGENTS.md link target doesn't exist yet.Checks
bun test(126 pass),bun run typecheck,bun run lintpass. Lint shows one warning that is already on main (unusedstatSyncimport insrc/node/index.ts).