Skip to content

Enable the sctx-dev contributor plugin and its review check - #47

Merged
mindsocket merged 4 commits into
mainfrom
sctx-dev-review
Nov 18, 2026
Merged

mindsocket merged 4 commits into
mainfrom
sctx-dev-review

Conversation

@mindsocket

Copy link
Copy Markdown
Owner

Enables structured-context's sctx-dev contributor plugin in this repo (mindsocket/structured-context#242). It brings the doc-review and test-review skills and a Stop hook that blocks while the branch adds docs, code comments or tests that no review has seen.

  • .claude/settings.json adds the structured-context marketplace and enables sctx-dev@structured-context.
  • lefthook.yml pre-push runs the plugin's review-check.sh from the installed marketplace when it is present, and otherwise prints review-check: sctx-dev plugin not installed, skipping and passes.
  • .gitattributes marks packages/map-views/src/node/bundled-definitions.ts as linguist-generated, so the check leaves it out (it also collapses in GitHub diffs).
  • AGENTS.md says what the hook and pre-push check and where they come from.

Until mindsocket/structured-context#242 merges, the marketplace has no sctx-dev, so pre-push skips the check and the AGENTS.md link target doesn't exist yet.

Checks

  • bun test (126 pass), bun run typecheck, bun run lint pass. Lint shows one warning that is already on main (unused statSync import in src/node/index.ts).
  • Pre-push review-check exercised both ways: with the plugin's script in place it exits 2 and lists the unreviewed lines; without it, it prints the skip note and passes.

Comment thread AGENTS.md Outdated
bun run build # the library, then the navigator
```

The Stop hook and pre-push block while the branch adds docs, code comments or tests that the `doc-review` or `test-review` skill has not seen. Both come from structured-context's [contributor plugin](https://github.com/mindsocket/structured-context/blob/main/docs/architecture.md#contributor-plugin), which `.claude/settings.json` enables.

@mindsocket mindsocket Nov 18, 2026 •

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unnecessary. If it's necessary the hook and pre-push should instead say more until it's self explanatory. Assume agents will know what to do, don't point at docs or point out details that aren't actionable, important and non-obvious

@mindsocket
mindsocket marked this pull request as ready for review November 18, 2026 12:05
The plugin from structured-context's marketplace brings the doc-review
and test-review skills and a Stop hook that blocks while the branch adds
docs, code comments or tests no review has seen. Pre-push runs the same
check when the plugin is installed and skips it with a note otherwise.

.gitattributes marks the generated bundled-definitions.ts so the check
leaves it out.
@mindsocket
mindsocket merged commit 1405d45 into main Nov 18, 2026
1 check passed
@mindsocket
mindsocket deleted the sctx-dev-review branch November 18, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant