Skip to content

Review docs and tests across the repo - #48

Merged
mindsocket merged 1 commit into
mainfrom
repo-review
Nov 18, 2026
Merged

mindsocket merged 1 commit into
mainfrom
repo-review

Conversation

@mindsocket

Copy link
Copy Markdown
Owner

Whole-repo doc-review and test-review against main, closing off the 1.0 cleanup.

Docs and comments

  • AGENTS.md: shorter term rule; the setting-scope rule moves here from definitions.md (it guides format design, not definition authors); drop the tests row that restated the test principle, and the reason sentence in Styling.
  • README: the test:package description now matches what it does (plugin too, renders a page).
  • definitions.md: drop the shared-settings list and the mapViewsForSchema line (owned by api.md).
  • api.md, components/layout.ts: use the focus term.
  • vite.config.ts, node/index.ts: drop comments that restated code or docs/definitions.md; remove an unused import.

Tests

  • Removed: matches definitions to a schema (covered by the mapViewsForSchema block), three rejects rows that only re-tested JSON Schema (required regions, required $id, $id pattern), accepts no issues.
  • passes validation options was vacuous. Measured: the sample has 0 rule issues, so a filter that is ignored also passed. It now passes an invalid filter and expects validateSpace's error.
  • Landscape, tree and XY counts are now derived from the fixture instead of hard-coded.

Checks: bun test (121 pass), typecheck, lint, test:package.

Docs: drop restated lists and duplicated passages, move the setting-scope rule
to AGENTS.md, correct the test:package description, use the focus term.
Tests: drop tests and schema-only rows other tests cover, derive fixture counts,
make the validation-options test fail when the option is ignored.
@mindsocket
mindsocket merged commit b4fb4de into main Nov 18, 2026
1 check passed
@mindsocket
mindsocket deleted the repo-review branch November 18, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant