Repository navigation
Review docs and tests across the repo - #48
Merged
Merged
Conversation
Docs: drop restated lists and duplicated passages, move the setting-scope rule to AGENTS.md, correct the test:package description, use the focus term. Tests: drop tests and schema-only rows other tests cover, derive fixture counts, make the validation-options test fail when the option is ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whole-repo doc-review and test-review against main, closing off the 1.0 cleanup.
Docs and comments
test:packagedescription now matches what it does (plugin too, renders a page).mapViewsForSchemaline (owned by api.md).Tests
matches definitions to a schema(covered by themapViewsForSchemablock), threerejectsrows that only re-tested JSON Schema (requiredregions, required$id,$idpattern),accepts no issues.passes validation optionswas vacuous. Measured: the sample has 0 rule issues, so a filter that is ignored also passed. It now passes an invalid filter and expects validateSpace's error.Checks:
bun test(121 pass), typecheck, lint,test:package.