Repository navigation
sctx-dev: contributor plugin with doc-review, test-review and the review check - #242
Merged
Merged
Conversation
…eview and the review check Adds a second plugin to the marketplace, for contributors to the structured-context repositories rather than users: - doc-review moves out of .claude/skills and refers to the repo's own AGENTS.md and definition of done, so it works in any of the repos. - test-review checks new and changed tests for duplication, schema re-testing, repeated code paths, self-fulfilling assertions, hard-coded lists and tests a change leaves redundant. - scripts/review-check.sh replaces scripts/prose-check.sh. It checks two kinds, prose and tests, each with its own review stamp and --mark, skips paths marked linguist-generated, and gives its fetch of origin/main 10 seconds. - The Stop hook runs the check in the session's repo, or in each checkout directly under the folder a session starts in. This repo enables the plugin in .claude/settings.json and calls the script from pre-push.
…SubagentStop A subagent in its own worktree now gets the review check for that worktree when it stops; measured: SubagentStop's cwd is the subagent's worktree. Also marks schemas/generated and bun.lock as generated.
mindsocket
commented
Nov 18, 2026
…r and links the check The section repeated what review-check.sh and on-stop.sh document. The marketplace entry no longer repeats the plugin manifest's description.
…ibe, and reports every check A review that looked only at changed lines, without reading the code a passage described, passed a section that duplicated the scripts' own comments.
mindsocket
marked this pull request as ready for review
November 18, 2026 11:58
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
sctx-dev, a second plugin in this repo's marketplace, for contributors to the structured-context repositories rather than users.doc-reviewmoves from.claude/skills/into the plugin and refers to the repo's ownAGENTS.md, glossary and definition of done, so it works in any of the repos.test-reviewskill: flags tests that duplicate another, re-test a JSON Schema, take an already-covered code path, assert what their own setup makes true, hard-code lists that grow with the code, or that a change leaves redundant.dev-plugin/scripts/review-check.shreplacesscripts/prose-check.sh. It checks two kinds, prose (docs and code comments) and tests, each with its own review stamp and--mark. Paths markedlinguist-generatedin.gitattributesare skipped. The fetch oforigin/mainis capped at 10 seconds..claude/settings.json(replacing the project Stop hook for the prose check) and calls the script from pre-push.docs/architecture.md#contributor-pluginlabel the plugin as contributor tooling.The plugin has no version, so installs follow the marketplace's commits.
Checks
bun run test,bun run typecheck,bun run lint,bun run test:hookpass.claude plugin validate dev-pluginpasses (warnings: no version, author or icon).