Skip to content

sctx-dev: contributor plugin with doc-review, test-review and the review check - #242

Merged
mindsocket merged 4 commits into
mainfrom
sctx-dev-plugin
Nov 18, 2026
Merged

mindsocket merged 4 commits into
mainfrom
sctx-dev-plugin

Conversation

@mindsocket

Copy link
Copy Markdown
Owner

Adds sctx-dev, a second plugin in this repo's marketplace, for contributors to the structured-context repositories rather than users.

  • doc-review moves from .claude/skills/ into the plugin and refers to the repo's own AGENTS.md, glossary and definition of done, so it works in any of the repos.
  • New test-review skill: flags tests that duplicate another, re-test a JSON Schema, take an already-covered code path, assert what their own setup makes true, hard-code lists that grow with the code, or that a change leaves redundant.
  • dev-plugin/scripts/review-check.sh replaces scripts/prose-check.sh. It checks two kinds, prose (docs and code comments) and tests, each with its own review stamp and --mark. Paths marked linguist-generated in .gitattributes are skipped. The fetch of origin/main is capped at 10 seconds.
  • The plugin's Stop hook runs the check in the session's repo, or in each checkout directly under the folder a session starts in.
  • This repo enables the plugin in .claude/settings.json (replacing the project Stop hook for the prose check) and calls the script from pre-push.
  • The marketplace entry and docs/architecture.md#contributor-plugin label the plugin as contributor tooling.

The plugin has no version, so installs follow the marketplace's commits.

Checks

  • bun run test, bun run typecheck, bun run lint, bun run test:hook pass.
  • claude plugin validate dev-plugin passes (warnings: no version, author or icon).
  • Pre-push (check-plugin-version, pushed-tree, review-check) passed on push.

…eview and the review check

Adds a second plugin to the marketplace, for contributors to the
structured-context repositories rather than users:

- doc-review moves out of .claude/skills and refers to the repo's own
  AGENTS.md and definition of done, so it works in any of the repos.
- test-review checks new and changed tests for duplication, schema
  re-testing, repeated code paths, self-fulfilling assertions, hard-coded
  lists and tests a change leaves redundant.
- scripts/review-check.sh replaces scripts/prose-check.sh. It checks two
  kinds, prose and tests, each with its own review stamp and --mark,
  skips paths marked linguist-generated, and gives its fetch of
  origin/main 10 seconds.
- The Stop hook runs the check in the session's repo, or in each checkout
  directly under the folder a session starts in.

This repo enables the plugin in .claude/settings.json and calls the
script from pre-push.
…SubagentStop

A subagent in its own worktree now gets the review check for that worktree when it
stops; measured: SubagentStop's cwd is the subagent's worktree. Also marks
schemas/generated and bun.lock as generated.
Comment thread .claude-plugin/marketplace.json Resolved
Comment thread docs/architecture.md Resolved
…r and links the check

The section repeated what review-check.sh and on-stop.sh document. The marketplace entry
no longer repeats the plugin manifest's description.
…ibe, and reports every check

A review that looked only at changed lines, without reading the code a passage
described, passed a section that duplicated the scripts' own comments.
@mindsocket
mindsocket marked this pull request as ready for review November 18, 2026 11:58
@claude

claude Bot commented Nov 18, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@mindsocket
mindsocket merged commit e56b75f into main Nov 18, 2026
3 checks passed
@mindsocket
mindsocket deleted the sctx-dev-plugin branch November 18, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant