Fix duplicate typename__ when type implements multiple interfaces - #460
Open
magicmark wants to merge 2 commits into
Open
Fix duplicate typename__ when type implements multiple interfaces#460magicmark wants to merge 2 commits into
magicmark wants to merge 2 commits into
Conversation
When a concrete type implements multiple interfaces and a query uses inline fragments on those interfaces (each selecting __typename), the codegen produces duplicate typename__ fields in the generated Pydantic model. This causes mypy to fail with: Name "typename__" already defined [no-redef] Co-Authored-By: Claude <noreply@anthropic.com>
When multiple inline fragments (targeting different interfaces a type implements) each select the same field, only keep the first occurrence. Co-Authored-By: Claude <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the bug from the xfail test —
_resolve_selection_setmerges fields from all matching inline fragments, so when a type implements interfaces Bar and Baz and both spreads select__typename, you get it twice.The fix deduplicates fields by name at the end of
_resolve_selection_set, keeping the first occurrence. All 924 existing tests pass unchanged.Stacked on #442.