fix(game-server): resolve memory leaks and improve shutdown cleanup

* Clean up pending disconnect timers to prevent memory leaks during server shutdown
* Remove stale `playerRoomIndex` entries when deleting rooms
* Delete Redis canvas data during room cleanup and add Pino logging for cleanup operations
* Add `SIGINT` (Ctrl+C) handling to the graceful shutdown sequence
* Include Redis connection cleanup as part of graceful shutdown

Author: mirza-mohammad24

apps/game-server/src/rooms/RoomManager.ts

@@ -6,6 +6,8 @@
 
 import { Player, RoomConfig, ErrorCode } from '@scribblitz/types';
 import { Room, ServerRoomState } from './Room';
+import { redis } from '../lib/redis';
+import logger from '../utils/logger';
 
 export class RoomManager {
   // Using a Map for O(1) lookups and efficient addition/removal of rooms
@@ -55,7 +57,21 @@ export class RoomManager {
 
     if (!room) return;
 
+    //Timer cleanup
     room.cleanup();
+
+    // Clean up the player index for ALL players who were in this room
+    // so they don't get stuck as "ghosts" in the RoomManager
+    for (const playerId of room.getState().players.keys()) {
+      this.playerRoomIndex.delete(playerId);
+    }
+
+    // Delete the Redis canvas stream to free up database RAM
+    // (Using fire-and-forget catch so we don't block room deletion if Redis hiccups)
+    redis.del(`room:${roomCode}:canvas`).catch((err: Error) => {
+      logger.error({ err, roomCode }, 'Failed to cleanup Redis canvas for deleted room');
+    });
+
     this.rooms.delete(roomCode);
   }
 

apps/game-server/src/server.ts

@@ -331,6 +331,8 @@ io.on('connection', (socket: Socket) => {
 
     //60 second cleanup timeout
     const timer = setTimeout(() => {
+      disconnectTimers.delete(userId); //Clean up the timer reference from the map after execution
+
       const roomCheck = roomManager.getRoom(roomCode);
       if (!roomCheck) return;
 
@@ -371,8 +373,6 @@ io.on('connection', (socket: Socket) => {
           void abortGame(io, roomCode);
         }
       }
-
-      disconnectTimers.delete(userId); //Clean up the timer reference from the map after execution
     }, 60_000);
 
     // Store the disconnect timer so it can be cleared if the user reconnects within the grace period
@@ -404,15 +404,27 @@ redis
   })
   .catch((err) => {
     logger.fatal({ err }, 'Redis fatal connection error');
+    process.exit(1);
   });
 
-// Graceful Shutdown to prevent Memory Leaks from orphan disconnect timers
-process.on('SIGTERM', () => {
-  logger.info('SIGTERM received — cleaning up disconnect timers');
+const gracefulShutdown = async (signal: string) => {
+  logger.info(`${signal} received — cleaning up disconnect timers and closing connections`);
   disconnectTimers.forEach((timer) => clearTimeout(timer));
   disconnectTimers.clear();
-  httpServer.close(() => {
+
+  httpServer.close(async () => {
+    try {
+      // FIX: Cleanly shut down the Redis connection to prevent socket leaks in the DB
+      await redis.quit();
+      logger.info('Redis connection closed.');
+    } catch (err) {
+      logger.error({ err }, 'Error closing Redis connection');
+    }
     logger.info('Server closed gracefully');
     process.exit(0);
   });
-});
+};
+
+// Graceful Shutdown to prevent Memory Leaks from orphan disconnect timers
+process.on('SIGTERM', () => gracefulShutdown('SIGTERM'));
+process.on('SIGINT', () => gracefulShutdown('SIGINT'));