Skip to content

Commit a3c2605

Browse files
chenghuichenrwightman
authored andcommitted
Set the default eval length for NaFlex ViT-B-16
1 parent 7a230ac commit a3c2605

2 files changed

Lines changed: 13 additions & 5 deletions

File tree

src/open_clip/model_configs/naflex_ViT-B-16.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
"custom_text": true,
44
"vision_cfg": {
55
"image_size": 224,
6+
"image_seq_len": 196,
67
"timm_model_name": "naflexvit_base_patch16_gap",
78
"timm_model_pretrained": false
89
},

tests/test_naflex_config.py

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,18 @@ def test_naflex_data_config_infers_budget_from_longest_row_cost():
4646
assert explicit.resolve_max_tokens_per_batch(batch_size=32, per_row_text_tokens=77) == 12345
4747

4848

49-
def test_siglip2_naflex_configs_default_to_384_dense_and_576_tokens():
50-
for model_name in ("ViT-B-16-SigLIP2-naflex", "ViT-SO400M-16-SigLIP2-naflex"):
51-
vision_cfg = open_clip.get_model_config(model_name)["vision_cfg"]
52-
assert vision_cfg["image_size"] == 384
53-
assert vision_cfg["image_seq_len"] == 576
49+
@pytest.mark.parametrize(
50+
("model_name", "image_size", "image_seq_len"),
51+
[
52+
("naflex_ViT-B-16", 224, 196),
53+
("ViT-B-16-SigLIP2-naflex", 384, 576),
54+
("ViT-SO400M-16-SigLIP2-naflex", 384, 576),
55+
],
56+
)
57+
def test_naflex_configs_define_nominal_image_seq_len(model_name, image_size, image_seq_len):
58+
vision_cfg = open_clip.get_model_config(model_name)["vision_cfg"]
59+
assert vision_cfg["image_size"] == image_size
60+
assert vision_cfg["image_seq_len"] == image_seq_len
5461

5562

5663
def test_naflex_data_config_rejects_negative_patch_size_probs():

0 commit comments

Comments
 (0)