Skip to content

Set the default eval length for NaFlex ViT-B-16 #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rwightman merged 1 commit into from
Jul 17, 2026
Merged

Set the default eval length for NaFlex ViT-B-16 #1197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/open_clip/model_configs/naflex_ViT-B-16.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"custom_text": true,
"vision_cfg": {
"image_size": 224,
"image_seq_len": 196,
"timm_model_name": "naflexvit_base_patch16_gap",
"timm_model_pretrained": false
},
Expand Down
17 changes: 12 additions & 5 deletions tests/test_naflex_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,18 @@ def test_naflex_data_config_infers_budget_from_longest_row_cost():
assert explicit.resolve_max_tokens_per_batch(batch_size=32, per_row_text_tokens=77) == 12345


def test_siglip2_naflex_configs_default_to_384_dense_and_576_tokens():
for model_name in ("ViT-B-16-SigLIP2-naflex", "ViT-SO400M-16-SigLIP2-naflex"):
vision_cfg = open_clip.get_model_config(model_name)["vision_cfg"]
assert vision_cfg["image_size"] == 384
assert vision_cfg["image_seq_len"] == 576
@pytest.mark.parametrize(
("model_name", "image_size", "image_seq_len"),
[
("naflex_ViT-B-16", 224, 196),
("ViT-B-16-SigLIP2-naflex", 384, 576),
("ViT-SO400M-16-SigLIP2-naflex", 384, 576),
],
)
def test_naflex_configs_define_nominal_image_seq_len(model_name, image_size, image_seq_len):
vision_cfg = open_clip.get_model_config(model_name)["vision_cfg"]
assert vision_cfg["image_size"] == image_size
assert vision_cfg["image_seq_len"] == image_seq_len


def test_naflex_data_config_rejects_negative_patch_size_probs():
Expand Down
Loading