fix: expand fixed-width \U+XXXX escapes and iterate by code point - #59
Merged
Merged
Conversation
Prevent greedy hex absorption after \U+XXXX (cad-viewer#615) and keep supplementary-plane characters from being split into UTF-16 surrogates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\U+XXXX(exactly four hex digits) before MText parsing so trailing hex digits are not absorbed (fixes cad-viewer#615, e.g.\U+22054.0→∅4.0)@mlightcad/mtext-parserto^1.5.1and package version to0.12.6; add unit tests and example coverageTest plan
pnpm --filter @mlightcad/mtext-renderer test -- test/renderer/unicodeEscapes.test.ts test/renderer/mtext.processor.test.ts\U+22054.0通renders as∅4.0通\U+D83D\U+DE00are treated as one code point each (missing glyph?is OK if font lacks emoji)