Repository navigation
chore(gha): update npm.yml GitHub workflow - #48
Merged
Merged
Conversation
ms-bot
force-pushed
the
mobsuccessbot/workflow-npm
branch
from
January 9, 2025 13:03
d2befe0 to
414cd5e
Compare
jvdadda
marked this pull request as draft
January 9, 2025 17:05
jvdadda
marked this pull request as ready for review
January 31, 2025 14:41
ms-bot
force-pushed
the
mobsuccessbot/workflow-npm
branch
3 times, most recently
from
February 26, 2025 14:42
2513a2f to
313183b
Compare
ms-bot
force-pushed
the
mobsuccessbot/workflow-npm
branch
from
August 12, 2025 08:55
313183b to
7ddbae0
Compare
jvdadda
marked this pull request as draft
October 14, 2025 09:32
ms-bot
force-pushed
the
mobsuccessbot/workflow-npm
branch
from
October 15, 2025 08:53
7ddbae0 to
914aaaf
Compare
ms-bot
force-pushed
the
mobsuccessbot/workflow-npm
branch
from
November 26, 2025 08:51
914aaaf to
2bbe86a
Compare
ms-bot
force-pushed
the
mobsuccessbot/workflow-npm
branch
from
December 16, 2025 07:51
2bbe86a to
1ccd8c1
Compare
ms-bot
force-pushed
the
mobsuccessbot/workflow-npm
branch
from
May 20, 2026 15:57
1ccd8c1 to
ae01953
Compare
ms-bot
force-pushed
the
mobsuccessbot/workflow-npm
branch
from
July 19, 2026 08:49
ae01953 to
8014b4e
Compare
ms-bot
force-pushed
the
mobsuccessbot/workflow-npm
branch
from
August 4, 2026 10:57
8014b4e to
60025b2
Compare
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
jvdadda
marked this pull request as ready for review
September 1, 2026 08:32
jvdadda
approved these changes
Sep 1, 2026
jvdadda
approved these changes
Sep 1, 2026
jvdadda
left a comment
jvdadda
left a comment
Contributor
There was a problem hiding this comment.
Sync npm.yml + tri de package.json. LGTM.
There was a problem hiding this comment.
Pull request overview
Updates the repository’s NPM GitHub Actions workflow to newer runner/tooling versions and introduces a sort-package-json check, with a corresponding package.json reordering to satisfy/align with the new linting expectations.
Changes:
- Bumps
npm.ymljobs toubuntu-24.04and updates action versions used within the workflow. - Adds a new
sortpackagejsonjob that checkspackage.jsonordering viasort-package-json. - Reorders keys in
package.json(including movingpublishConfig) and reorders thescriptsentries.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Reorders metadata and script entries; keeps publishConfig while adjusting key ordering. |
| .github/workflows/npm.yml | Updates CI runner/tooling versions and adds a sort-package-json verification job to the workflow. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+33
to
+49
| - name: Cache Node Modules | ||
| id: cache | ||
| uses: actions/cache@v6 | ||
| env: | ||
| cache-name: cache-node-modules | ||
| with: | ||
| path: ./node_modules | ||
| key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package.json') }}-${{ hashFiles('**/package-lock.json') }}-node-24 | ||
| - run: echo "//npm.pkg.github.com/:_authToken=${{ secrets.MS_READ_PACKAGES_GITHUB_PAT }}" >> ~/.npmrc | ||
| name: Configure Credentials For GitHub Packages | ||
| - run: npm ci | ||
| if: steps.cache.outputs.cache-hit != 'true' | ||
| working-directory: . | ||
| - run: | | ||
| echo "💡 👉 Check not passing? see the doc at https://www.notion.so/mobsuccess/sort-package-json-de5cf4648e8545dbb5a2a5a910380535" | ||
| npx --yes sort-package-json@2.4.1 --check | ||
| working-directory: . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this needed?
This pull request has been created by a robot to update the
npm.ymlGitHub workflow.