Repository navigation
fix(ci): publish a plain amd64 manifest, so the image runs on Apple Silicon [FTTECH-15471] - #12
Merged
Merged
Conversation
…ilicon [FTTECH-15471] Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The change is a small, targeted workflow input update that aligns with the stated goal and is supported by the referenced action version.
Review effort: Lite
Findings: None
What changed in this PR
This PR adjusts the container publishing workflow so the v3.13.0 image is pushed as a plain linux/amd64 manifest (not an OCI index), restoring the ability to docker run the image on Apple Silicon via emulation.
Changes:
- Disable BuildKit provenance attestations in
docker/build-push-actionto avoid publishing an OCI index with anunknown/unknownentry.
| File | Description |
|---|---|
| .github/workflows/docker.yml | Disables provenance generation during build/push so published tags become plain linux/amd64 manifests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
florentsorel
added
the
maximus-auto-merge-fast
Maximus fast — Ready to merge ✅Every required gate passed on Required actionNo action required: the verified GitHub merge strategy will be applied. Check status
|
![maximus-agents[bot]](https://avatars.githubusercontent.com/in/4026537?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does It Do?
Adds
provenance: falseto thedocker/build-push-actionstep, so thatv3.13.0is published as a plainlinux/amd64image manifest instead of an OCI index.Context
docker/build-push-actionadds a provenance attestation by default: each tag becomes an OCI index withlinux/amd64and anunknown/unknownentry. On an Apple Silicon Mac, Docker refuses an index without its platform (no matching manifest for linux/arm64/v8 in the manifest list entries), so the PHP-CS-Fixer target of themobsuccessMakefile no longer runs there since the move to ghcr.io. The ECR Public image was a plain amd64 manifest, which Docker ran under emulation with a warning: this restores that behaviour. CI runners are amd64 and are not affected.Checked locally on an Apple Silicon Mac, with a throwaway registry and a
docker-containerbuilder as in CI: the image pushed by default is refused bydocker run; pushed withprovenance: false, it runs under emulation. The only loss is the SLSA provenance attestation, which nothing consumes. The same change goes into the four other image repositories (FTTECH-15466).Merging republishes
v3.13.0, with the same phar, checked against its SHA-256 during the build.Test Plan
actionlint: nothing reportedDockerrun builds the imagev3.13.0is a plain manifest (application/vnd.oci.image.manifest.v1+json) anddocker runstarts it on an Apple Silicon Mac🤖 Generated with Claude Code