Repository navigation
chore(php): run php-cs-fixer image on PHP 8.2 Alpine - #14
Closed
nicolasotmani wants to merge 1 commit into
Closed
nicolasotmani wants to merge 1 commit into
nicolasotmani wants to merge 1 commit into
Conversation
Keep Fixer 3.13.0 rules; set PHP_CS_FIXER_IGNORE_ENV until a Fixer >=3.15 bump. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
No open issues 🎉
What changed in this PR
Updates the PHP-CS-Fixer container to PHP 8.2 Alpine while retaining Fixer 3.13.0 compatibility.
Changes:
- Switches the base image to
php:8.2-alpine. - Sets
PHP_CS_FIXER_IGNORE_ENV=1. - Documents the runtime and compatibility strategy.
| File | Description |
|---|---|
README.md |
Documents the updated runtime configuration. |
entrypoint.sh |
Enables Fixer execution on PHP 8.2. |
Dockerfile |
Uses the PHP 8.2 Alpine base image. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does It Do?
Switch the CS Fixer GHCR image base from
php:8.1.34-alpinetophp:8.2-alpine, keep Fixer 3.13.0, setPHP_CS_FIXER_IGNORE_ENV=1so 3.13.0 can run on PHP 8.2.Context
Aligns the fixer runtime with the mobsuccess PHP 8.2 upgrade. Official Fixer PHP 8.2 support starts at ≥3.15.0 (ruleset bump — separate PR). Pin
php:8.2.35-cli-alpinewhen Hub publishes it.Test Plan
docker compose buildlocallydocker run … --versionshows PHP 8.2.x + Fixer 3.13.0make php-cs-fixerdry-run still works after GHCR publish from masterMade with Cursor