fix: show skipped instead of pending for this.skip() - #6229
Open
arronKler wants to merge 1 commit into
Open
Conversation
Tests skipped at runtime via this.skip() were reported as pending, the same label used for unimplemented tests. Keep empty it() cases as pending and display skipped for this.skip() in reporters. Fixes mochajs#5138
|
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
skipshows "pending" instead of "skipped" #5138status: accepting prsOverview
this.skip()was reported as pending, the same label used for unimplemented tests (it('title')with no callback). That made skipped tests look unfinished.This keeps the pending event and stats as they are, and only changes the displayed text:
this.skip()is markedskippedand reporters show "skipped"HTML hover text is
(skipped)forthis.skip()and(pending)otherwise. Spec/list append(skipped)for skipped tests, and the epilogue reports skipped vs pending separately.Fixes #5138