fix: apply require root hooks in programmatic serial runs - #6232
Open
arronKler wants to merge 1 commit into
Open
fix: apply require root hooks in programmatic serial runs#6232arronKler wants to merge 1 commit into
arronKler wants to merge 1 commit into
Conversation
CLI and worker startup already load mochaHooks from --require. Programmatic serial runs did not, so those root hooks never ran. Fixes mochajs#5006
|
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
--requirefiles that exportmochaHooksalready run under the CLI and in parallel workers, because both callhandleRequiresbefore constructingMocha. A programmatic serial run (new Mocha({ require })) never did that, so the root hooks were skipped.Mocha#runnow loads those plugins whenrootHookswas not already supplied.handleRequireslives inlib/nodejsso the Mocha class does not import CLI helpers.Fixes #5006