You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 4d9e11b
Browse filesBrowse the repository at this point in the historyBrowse files
HttpClientStreamableTransport: fix race condition on 404 response
- There was a race condition where a 404 to a sendMessage call triggered
client-side session closing. This would ultimately close open
connections, including the POST for the sendMessage itself if it had
not completed by then. This would cancel the Mono instead of
propagating the error.
- This was a race condition because before closing the connection, the
DefaultMcpTransportSession needed to send a DELETE to the server, and
waited for the response. Cancelling happened only when DELETE finished
before sendMessage() finished, so it would not show often.
- This materialized in CI as errors for `test404WithSessionId`.
Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
0 commit comments