|
10 | 10 | import org.junit.jupiter.api.Test; |
11 | 11 |
|
12 | 12 | import static org.assertj.core.api.Assertions.assertThat; |
| 13 | +import static org.assertj.core.api.Assertions.assertThatThrownBy; |
13 | 14 |
|
14 | 15 | /** |
15 | | - * Tests for {@link McpTransportContext#create(Map)}, which is documented to return an |
16 | | - * unmodifiable context. |
| 16 | + * Tests for {@link McpTransportContext}: {@link McpTransportContext#create(Map)}, which |
| 17 | + * is documented to return an unmodifiable context, and |
| 18 | + * {@link McpTransportContext#putAll(Map)}. |
17 | 19 | */ |
18 | 20 | class McpTransportContextTests { |
19 | 21 |
|
@@ -51,39 +53,130 @@ void createdContextShouldNotBeEmptiedByClearingTheSourceMap() { |
51 | 53 | } |
52 | 54 |
|
53 | 55 | @Test |
54 | | - void createdContextShouldRemainUsableAsAMapKey() { |
55 | | - Map<String, Object> metadata = new HashMap<>(); |
56 | | - metadata.put("tenant", "acme"); |
57 | | - McpTransportContext context = McpTransportContext.create(metadata); |
58 | | - |
59 | | - Map<McpTransportContext, String> byContext = new HashMap<>(); |
60 | | - byContext.put(context, "value"); |
61 | | - metadata.put("tenant", "other"); |
| 56 | + void createdContextFromAnImmutableMapIsAlreadyCorrect() { |
| 57 | + McpTransportContext context = McpTransportContext.create(Map.of("tenant", "acme")); |
62 | 58 |
|
63 | | - assertThat(byContext.get(context)).isEqualTo("value"); |
| 59 | + assertThat(context.get("tenant")).isEqualTo("acme"); |
64 | 60 | } |
65 | 61 |
|
66 | 62 | @Test |
67 | | - void twoContextsCreatedFromEqualMapsShouldStayEqual() { |
68 | | - Map<String, Object> first = new HashMap<>(); |
69 | | - first.put("tenant", "acme"); |
70 | | - Map<String, Object> second = new HashMap<>(); |
71 | | - second.put("tenant", "acme"); |
| 63 | + void putAllShouldKeepTheEntriesOfTheContextAndTheMap() { |
| 64 | + McpTransportContext context = McpTransportContext.create(Map.of("tenant", "acme")); |
72 | 65 |
|
73 | | - McpTransportContext firstContext = McpTransportContext.create(first); |
74 | | - McpTransportContext secondContext = McpTransportContext.create(second); |
75 | | - assertThat(firstContext).isEqualTo(secondContext); |
| 66 | + McpTransportContext merged = context.putAll(Map.of("region", "eu")); |
76 | 67 |
|
77 | | - first.put("tenant", "other"); |
| 68 | + assertThat(merged.get("tenant")).isEqualTo("acme"); |
| 69 | + assertThat(merged.get("region")).isEqualTo("eu"); |
| 70 | + } |
78 | 71 |
|
79 | | - assertThat(firstContext).isEqualTo(secondContext); |
| 72 | + @Test |
| 73 | + void putAllShouldLetTheMapWinOnSharedKeys() { |
| 74 | + McpTransportContext context = McpTransportContext.create(Map.of("tenant", "acme")); |
| 75 | + |
| 76 | + assertThat(context.putAll(Map.of("tenant", "other")).get("tenant")).isEqualTo("other"); |
80 | 77 | } |
81 | 78 |
|
82 | 79 | @Test |
83 | | - void createdContextFromAnImmutableMapIsAlreadyCorrect() { |
| 80 | + void putAllShouldLeaveTheOriginalContextUnchanged() { |
84 | 81 | McpTransportContext context = McpTransportContext.create(Map.of("tenant", "acme")); |
85 | 82 |
|
| 83 | + context.putAll(Map.of("tenant", "other", "region", "eu")); |
| 84 | + |
86 | 85 | assertThat(context.get("tenant")).isEqualTo("acme"); |
| 86 | + assertThat(context.get("region")).isNull(); |
| 87 | + } |
| 88 | + |
| 89 | + @Test |
| 90 | + void putAllShouldNotSeeLaterWritesToTheSourceMap() { |
| 91 | + Map<String, Object> entries = new HashMap<>(); |
| 92 | + entries.put("region", "eu"); |
| 93 | + |
| 94 | + McpTransportContext merged = new LookupTransportContext(Map.of()).putAll(entries); |
| 95 | + entries.put("region", "us"); |
| 96 | + |
| 97 | + assertThat(merged.get("region")).isEqualTo("eu"); |
| 98 | + } |
| 99 | + |
| 100 | + @Test |
| 101 | + void putAllWithAnEmptyMapShouldReturnTheSameContext() { |
| 102 | + McpTransportContext context = McpTransportContext.create(Map.of("tenant", "acme")); |
| 103 | + McpTransportContext custom = new LookupTransportContext(Map.of("tenant", "acme")); |
| 104 | + |
| 105 | + assertThat(context.putAll(Map.of())).isSameAs(context); |
| 106 | + assertThat(custom.putAll(Map.of())).isSameAs(custom); |
| 107 | + } |
| 108 | + |
| 109 | + @Test |
| 110 | + void putAllOnTheDefaultContextShouldHoldTheMergedEntries() { |
| 111 | + McpTransportContext context = McpTransportContext.create(Map.of("tenant", "acme", "region", "us")); |
| 112 | + |
| 113 | + McpTransportContext merged = context.putAll(Map.of("region", "eu")); |
| 114 | + |
| 115 | + assertThat(merged.get("tenant")).isEqualTo("acme"); |
| 116 | + assertThat(merged.get("region")).isEqualTo("eu"); |
| 117 | + assertThat(merged.get("missing")).isNull(); |
| 118 | + } |
| 119 | + |
| 120 | + @Test |
| 121 | + void putAllShouldRejectNullValues() { |
| 122 | + Map<String, Object> withNullValue = new HashMap<>(); |
| 123 | + withNullValue.put("region", null); |
| 124 | + |
| 125 | + assertThatThrownBy(() -> McpTransportContext.create(Map.of()).putAll(withNullValue)) |
| 126 | + .isInstanceOf(NullPointerException.class); |
| 127 | + assertThatThrownBy(() -> new LookupTransportContext(Map.of()).putAll(withNullValue)) |
| 128 | + .isInstanceOf(NullPointerException.class); |
| 129 | + } |
| 130 | + |
| 131 | + @Test |
| 132 | + void putAllOnACustomContextShouldDelegateLookupsForKeysNotInTheMap() { |
| 133 | + McpTransportContext custom = new LookupTransportContext(Map.of("tenant", "acme", "region", "us")); |
| 134 | + |
| 135 | + McpTransportContext merged = custom.putAll(Map.of("region", "eu")); |
| 136 | + |
| 137 | + assertThat(merged.get("tenant")).isEqualTo("acme"); |
| 138 | + assertThat(merged.get("region")).isEqualTo("eu"); |
| 139 | + assertThat(merged.get("missing")).isNull(); |
| 140 | + } |
| 141 | + |
| 142 | + @Test |
| 143 | + void putAllOnACustomContextShouldSeeLaterChangesToIt() { |
| 144 | + Map<String, Object> source = new HashMap<>(); |
| 145 | + McpTransportContext custom = new LookupTransportContext(source); |
| 146 | + |
| 147 | + McpTransportContext merged = custom.putAll(Map.of("region", "eu")); |
| 148 | + source.put("tenant", "acme"); |
| 149 | + |
| 150 | + assertThat(merged.get("tenant")).isEqualTo("acme"); |
| 151 | + } |
| 152 | + |
| 153 | + @Test |
| 154 | + void repeatedPutAllShouldHoldTheCombinedEntries() { |
| 155 | + McpTransportContext custom = new LookupTransportContext(Map.of("tenant", "acme")); |
| 156 | + |
| 157 | + McpTransportContext merged = custom.putAll(Map.of("region", "us")).putAll(Map.of("region", "eu", "zone", "a")); |
| 158 | + |
| 159 | + assertThat(merged.get("tenant")).isEqualTo("acme"); |
| 160 | + assertThat(merged.get("region")).isEqualTo("eu"); |
| 161 | + assertThat(merged.get("zone")).isEqualTo("a"); |
| 162 | + } |
| 163 | + |
| 164 | + /** |
| 165 | + * A context reading its backing map on each lookup. |
| 166 | + */ |
| 167 | + static class LookupTransportContext implements McpTransportContext { |
| 168 | + |
| 169 | + private final Map<String, Object> source; |
| 170 | + |
| 171 | + LookupTransportContext(Map<String, Object> source) { |
| 172 | + this.source = source; |
| 173 | + } |
| 174 | + |
| 175 | + @Override |
| 176 | + public Object get(String key) { |
| 177 | + return this.source.get(key); |
| 178 | + } |
| 179 | + |
87 | 180 | } |
88 | 181 |
|
89 | 182 | } |
0 commit comments