Skip to content

Commit f9665b8

Browse files
committed
Remove javadoc:aggregate from the publish workflows
javadoc:aggregate forks a compile-phase build of the whole reactor. mcp is compiled at prepare-package, so the fork never produces mcp classes, and modules depending on mcp (the conformance tests) fall back to the local or remote repository, where the current version may not exist. The aggregated javadoc was never attached or published; Maven Central only needs the per-module javadoc jars, which do not fork the reactor. Drop the aggregate execution from the javadoc profile and the standalone "Generate Java docs" step, and stop excluding the conformance tests from the release build. They are still not deployed (maven.deploy.skip and central-publishing excludeArtifacts). Closes #1190 Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
1 parent 53574e2 commit f9665b8

3 files changed

Lines changed: 0 additions & 14 deletions

File tree

‎.github/workflows/maven-central-release.yml‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,17 +32,13 @@ jobs:
3232
run: ./mvnw -pl mcp-test -am -Pjackson2 test
3333

3434
# Deploy runs all previous maven goals, including test and verify
35-
# Conformance tests are not published, and they break javadoc:aggregate: its forked
36-
# compile lifecycle never produces mcp classes (compiled at prepare-package), so their
37-
# dependency on mcp falls back to Maven Central, where the release does not exist yet.
3835
# Use the wrapper (Maven 3.9.x): with Maven 3.10, central-publishing 0.7.0 leaves
3936
# maven-metadata-local.xml files in the bundle, and Central rejects it.
4037
- name: Publish to Maven Central
4138
run: |
4239
./mvnw --batch-mode \
4340
-Prelease \
4441
-Pjavadoc \
45-
-pl '!conformance-tests,!conformance-tests/client-jdk-http-client,!conformance-tests/client-spring-http-client,!conformance-tests/server-servlet' \
4642
clean deploy
4743
env:
4844
MAVEN_USERNAME: ${{ secrets.OSSRH_USERNAME }}

‎.github/workflows/publish-snapshot.yml‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,6 @@ jobs:
2929
with:
3030
node-version: '20'
3131

32-
- name: Generate Java docs
33-
run: ./mvnw -Pjavadoc -B javadoc:aggregate
34-
3532
- name: Jackson 2 Integration Tests
3633
run: ./mvnw -pl mcp-test -am -Pjackson2 test
3734

‎pom.xml‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -311,13 +311,6 @@
311311
<goal>jar</goal>
312312
</goals>
313313
</execution>
314-
<execution>
315-
<id>generate-aggregate-javadocs</id>
316-
<phase>package</phase>
317-
<goals>
318-
<goal>aggregate</goal>
319-
</goals>
320-
</execution>
321314
</executions>
322315
</plugin>
323316
</plugins>

0 commit comments

Comments
 (0)