You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
HttpServletStreamableServerTransportProvider leaves session sweeper thread alive after close #1342
Since MCP Java SDK 2.1.0, constructing and closing an
HttpServletStreamableServerTransportProvider leaves one live, non-daemon streamable-http-server-transport-session-sweeper thread. Repeating the
create/close cycle accumulates threads and can prevent the JVM from exiting.
This reproduces without a servlet container or an MCP client.
Versions and result
Tested on JDK 25 with mcp-core and mcp-json-jackson2 at matching versions:
Version
Live sweeper threads after one close
2.0.1
0 (sweeper not present)
2.1.0
1, non-daemon
2.2.0
1, non-daemon
The same behavior occurs when the transport is used in a real server: after
two start/stop cycles, two sweeper threads remain and the JVM does not exit.
closeGracefully().block() (and destroy()) should stop transport-owned
background work. Repeated create/close cycles should not accumulate threads,
and the JVM should be able to exit normally. Session eviction must continue
to work while the provider is running.
Likely cause and suggested fix
startSessionSweeper() creates a dedicated Schedulers.newSingle(...) for Flux.interval(...), but retains only the Flux subscription Disposable. closeGracefully() disposes the subscription, not the scheduler, leaving its
non-daemon thread alive. destroy() delegates to the same close path.
Please retain ownership of the Scheduler and dispose it during normal close
and failed-start cleanup, alongside the subscription. Cleanup should be
idempotent. A regression test should cover repeated create/close cycles,
thread termination, continued idle-session eviction, and active-stream close.
Disabling session sweeping or merely making its thread daemon would conceal
the lifecycle bug and/or undo idle-session cleanup.
Related: #1130 introduced session sweeping. This is distinct from the
HttpClient SelectorManager leak in #620 and the disconnected-client socket
issue in #1021.
Activity