Repository navigation
Conversation
Drop a suspended handshake-era handler fiber when the client sends notifications/cancelled, and do not answer the cancelled request. Unknown, already-finished and un-cancellable ids are ignored.
ump45nose
requested review from
CodeWithKyrian,
Nyholm,
chr-hertel and
soyuka
as code owners
November 10, 2026 23:27
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handle
notifications/cancelledon handshake-era servers by dropping the suspended handler fiber (for example one waiting on elicitation or sampling) and not answering the cancelled request. Unknown, already-finished and un-cancellable ids are ignored. 2026-07-28 stdio cancellation ofsubscriptions/listenis unchanged.TransportInterface::setCancellationChecker()is new: transports that extendBaseTransportget it automatically; a custom implementor must add the setter and drop a cancelled fiber from the polling loop without sending a response.Fixes #732
Verification
ProtocolTest cancellation cases, StdioSuspendedFibersTest, StreamableHttpTransportTest SSE drop, StdioDualEraTest, StdioTransportTest, ProtocolSessionLockTest; 241 tests, 961 assertions. Re-ran 7 cancel-focused tests after adding the 0.11.0 CHANGELOG [BC Break] for
TransportInterface::setCancellationChecker(); OK (7 tests, 41 assertions).