Skip to content

Commit 18eece6

Browse files
modified the tests
1 parent 3c63a53 commit 18eece6

1 file changed

Lines changed: 7 additions & 17 deletions

File tree

‎tests/server/skills/test_catalog.py‎

Lines changed: 7 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
ListSkillsHandler,
2828
ReadDirectoryHandler,
2929
SkillCatalog,
30+
SkillProvider,
3031
)
3132
from mcp.shared.exceptions import MCPError
3233
from mcp.shared.skills import (
@@ -650,25 +651,14 @@ async def test_a_page_size_below_one_is_rejected_when_the_catalog_loads(page_siz
650651
await SkillCatalog.load(provider, parse_frontmatter=_parse, page_size=page_size)
651652

652653

653-
async def test_a_negative_ttl_is_rejected_when_the_catalog_loads() -> None:
654-
"""SEP-2549: `ttlMs` is a non-negative integer, so a bad option fails at load rather than on every request."""
655-
provider = _MemoryProvider({"git-workflow/SKILL.md": _skill_md("git-workflow")})
656-
with pytest.raises(ValueError):
657-
await SkillCatalog.load(provider, parse_frontmatter=_parse, ttl_ms=-1)
658-
659-
660-
async def test_invalid_options_are_rejected_before_the_provider_is_touched() -> None:
661-
"""SDK-defined: option errors surface before any provider call; a call would raise `NotImplementedError`."""
662-
663-
class _UntouchableProvider:
664-
async def list_files(self) -> Sequence[str]: # pragma: no cover
665-
raise NotImplementedError
666-
667-
async def read_file(self, path: str) -> bytes: # pragma: no cover
668-
raise NotImplementedError
654+
async def test_a_negative_ttl_is_rejected_before_the_provider_is_used() -> None:
655+
"""SEP-2549: `ttlMs` is non-negative, and a bad option fails at load before the provider is scanned.
669656
657+
The provider has no methods, so reaching it would raise `AttributeError` instead of `ValueError`.
658+
"""
659+
provider = cast(SkillProvider, object())
670660
with pytest.raises(ValueError):
671-
await SkillCatalog.load(_UntouchableProvider(), parse_frontmatter=_parse, ttl_ms=-1)
661+
await SkillCatalog.load(provider, parse_frontmatter=_parse, ttl_ms=-1)
672662

673663

674664
async def test_load_returns_an_instance_of_the_subclass_it_is_called_on() -> None:

0 commit comments

Comments
 (0)