Enforce the intake gate from merge; keep PR_GATE_ENFORCE=false as a kill switch

No-Verification-Needed: workflow config only
Signed-off-by: Max Isbey <224885523+maxisbey@users.noreply.github.com>

Author: maxisbey

.github/scripts/pr_intake_gate.js

@@ -10,8 +10,8 @@
 // the label, or adding `bypass-issue-check` overrides it, and the override
 // sticks.
 //
-// Everything that writes goes through mutate(), so with ENFORCE unset the run
-// only logs what it would have done.
+// Everything that writes goes through mutate(); when the workflow passes
+// ENFORCE=false (its kill switch) the run only logs what it would have done.
 'use strict';
 
 const LABEL = 'missing-issue-link'; // marks PRs the gate has closed

.github/scripts/pr_intake_gate.test.js

@@ -228,7 +228,7 @@ for (const s of scenarios) {
   });
 }
 
-test('dry run (PR_GATE_ENFORCE unset) reaches the same verdicts but writes nothing', async () => {
+test('kill switch (ENFORCE=false) reaches the same verdicts but writes nothing', async () => {
   for (const s of scenarios) {
     const world = makeWorld(s);
     await run(world, s.event, { enforce: false });

.github/workflows/require-linked-issue.yml

@@ -9,7 +9,8 @@
 # `bypass-issue-check` overrides.
 #
 # Operating it:
-#   - Dry-run until the repository variable PR_GATE_ENFORCE is set to "true".
+#   - Live by default. To pause it without a revert, set the repository
+#     variable PR_GATE_ENFORCE to "false": runs then only log their verdicts.
 #   - PRs below the number in the job `if:` predate the gate and are ignored
 #     unless evaluated by hand: `gh workflow run require-linked-issue.yml -f pr_number=N`.
 #
@@ -67,7 +68,7 @@ jobs:
       issues: write # read linked issues; label and comment on the PR
       pull-requests: write # close and reopen the PR
     env:
-      ENFORCE: ${{ vars.PR_GATE_ENFORCE == 'true' && 'true' || 'false' }}
+      ENFORCE: ${{ vars.PR_GATE_ENFORCE != 'false' && 'true' || 'false' }} # kill switch: set the variable to "false" to go log-only
       PR_NUMBER_INPUT: ${{ inputs.pr_number }}
     steps:
       - name: Check out the gate script (default branch)