Repository navigation
Deflake the session-level timeout test with trio's virtual clock - #2788
Merged
Merged
Claude / Claude Code Review
completed
Jun 5, 2026 in 32m 37s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | tests/interaction/lowlevel/test_timeouts.py:90-103 |
tests/interaction/README.md still calls these 'real-clock timeout tests' |
Annotations
Check warning on line 103 in tests/interaction/lowlevel/test_timeouts.py
claude / Claude Code Review
tests/interaction/README.md still calls these 'real-clock timeout tests'
Nit: `tests/interaction/README.md` (line 64) still describes these as "the real-clock timeout tests" when explaining why they skip the transport-parametrized `connect` fixture, but after this change the session-level test runs on trio's MockClock virtual clock rather than the real clock. Consider rewording that phrase (e.g. just "the timeout tests") so the README stays consistent with the updated docstring and comments here.
Loading