Skip to content

Preserve empty issuer/resource paths on AuthSettings - #2987

Merged
Kludex merged 1 commit into
mainfrom
auth-settings-preserve-empty-path
Jun 26, 2026
Merged

Kludex merged 1 commit into
mainfrom
auth-settings-preserve-empty-path

Preserve empty issuer/resource paths on AuthSettings

92fae82
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Jun 26, 2026 in 11m 23s

Code review found 1 potential issue

Found 5 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit tests/server/auth/test_routes.py:51-65 New type: ignore comments in tests violate AGENTS.md guideline

Annotations

Check warning on line 65 in tests/server/auth/test_routes.py

See this annotation in the file changed.

@claude claude / Claude Code Review

New type: ignore comments in tests violate AGENTS.md guideline

These two new tests add four new `# type: ignore[arg-type]` comments, which AGENTS.md explicitly asks to avoid ("Avoid adding new # pragma: no cover, # type: ignore, or # noqa comments"). The same string-validation path can be exercised without the ignores via `AuthSettings.model_validate({"issuer_url": "https://as.example.com", "resource_server_url": "https://rs.example.com"})`, matching the pattern already used in tests/client/test_auth.py for OAuthMetadata.