Repository navigation
Publish versioning, roadmap, and dependency policies for v2 - #3215
Code review found 3 potential issues
Found 6 candidates, confirmed 3. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 3 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | VERSIONING.md:25 |
nit: VERSIONING.md gives contradictory answers on whether removing a spec-retired protocol feature's public API can happ |
| 🟡 Nit | RELEASE.md:13 |
nit: The rewritten step 2 describes the committed 'uv.lock' as "a normal, newest-allowed resolution", but the command th |
| 🟡 Nit | VERSIONING.md:11 |
[quality] nit: VERSIONING.md defines an "experimental" stability tier ("**experimental** APIs are opt-in previews", line |
Annotations
Check warning on line 25 in VERSIONING.md
claude / Claude Code Review
nit: VERSIONING.md gives contradictory answers on whether removing a spec-retired protocol feature's public API can happen in a minor: line 17 puts "removing or renaming a public name" in the "Held for the next major" list (and the Deprecations section, l
nit: VERSIONING.md gives contradictory answers on whether removing a spec-retired protocol feature's public API can happen in a minor: line 17 puts "removing or renaming a public name" in the "Held for the next major" list (and the Deprecations section, line 31, says SDK APIs "are removed only in a major"), while line 25 puts "the eventual removal of protocol features the specification has retired" in the "Allowed in a minor" list — but every retired protocol feature IS a set of exported publi
Check warning on line 13 in RELEASE.md
claude / Claude Code Review
nit: The rewritten step 2 describes the committed `uv.lock` as "a normal, newest-allowed resolution", but the command the same step prescribes (`uv lock`) is preference-preserving: uv re-resolves only what the pyproject change requires and keeps every oth
nit: The rewritten step 2 describes the committed `uv.lock` as "a normal, newest-allowed resolution", but the command the same step prescribes (`uv lock`) is preference-preserving: uv re-resolves only what the pyproject change requires and keeps every other package at its previously locked version (that is exactly why the step's own parenthetical offers `--upgrade-package` "to move just that package's locked version"). The repo's lock only approaches newest via Dependabot's monthly grouped updat
Check warning on line 11 in VERSIONING.md
claude / Claude Code Review
[quality] nit: VERSIONING.md defines an "experimental" stability tier ("**experimental** APIs are opt-in previews", line 11) and exempts it from the minor-release promise ("changes to provisional or experimental APIs", line 24), but v2 ships no API labell
[quality] nit: VERSIONING.md defines an "experimental" stability tier ("**experimental** APIs are opt-in previews", line 11) and exempts it from the minor-release promise ("changes to provisional or experimental APIs", line 24), but v2 ships no API labelled experimental — the migration guide's "Experimental Tasks support removed" section documents that every `mcp.*.experimental` module and property was deleted, and the only remaining "experimental" in the SDK is the protocol's `experimental` c