Repository navigation
fix(client/auth): discard stored client registrations whose secret has expired - #3264
Open
claude[bot] wants to merge 9 commits into
Open
claude[bot] wants to merge 9 commits into
claude[bot] wants to merge 9 commits into
Claude / Claude Code Review
completed
Aug 10, 2026 in 8m 1s
Code review found 2 potential issues
Found 2 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/mcp/client/auth/oauth2.py:869-881 |
403 step-up re-registration with no discovered AS metadata (restart) POSTs registration to the resource origin and bypas |
Annotations
Check warning on line 881 in src/mcp/client/auth/oauth2.py
claude / Claude Code Review
403 step-up re-registration with no discovered AS metadata (restart) POSTs registration to the resource origin and bypasses CIMD
The new 403 step-up re-registration assumes AS metadata has already been discovered, but after a process restart `_initialize()` restores only tokens and client info — so when a lapsed registration plus a still-live access token hits a 403 first, `context.oauth_metadata` is `None`, `should_use_client_metadata_url()` silently bypasses a configured CIMD URL, and `_prepare_client_registration()` POSTs the registration blind to `urljoin(resource_origin, "/register")` — which in the standard separate
Loading