Repository navigation
Claude / Claude Code Review
completed
Sep 17, 2026 in 22m 46s
Code review found 2 important issues
Found 36 candidates, confirmed 10. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 2 |
| 🟡 Nit | 8 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | examples/transports/mcp_transport_examples/grpc_server.py:154 |
Server handlers on this binding that send a connection-scoped notification fail their whole request with INVALID_REQUEST |
| 🔴 Important | examples/transports/mcp_transport_examples/grpc_server.py:121 |
Custom-method handlers whose dict result or 'MCPError.data' holds values the SDK's JSON-RPC transports serialize (dateti |
| 🟡 Nit | examples/transports/mcp_transport_examples/grpc_client.py:96 |
Callers passing tool arguments over 4 MiB or containing a NaN or infinite float get a bare 'ValueError' from 'call_tool' |
| 🟡 Nit | examples/transports/mcp_transport_examples/grpc_response.py:56 |
gRPC clients whose logging or message handlers do real work get REQUEST_TIMEOUT on requests the server answered in time, |
| 🟡 Nit | examples/transports/mcp_transport_examples/grpc_client.py:58 |
Users of the client adapter in an ordinary short-lived script (connect, call, close, exit) get 'Event loop is closed' er |
| 🟡 Nit | examples/transports/mcp_transport_examples/grpc_client.py:121 |
Clients rejected by the server's capacity cap or by payload validation are told the connection is closed, so retry and r |
| 🟡 Nit | examples/transports/tests/test_grpc_client_shutdown.py:76 |
nit: Maintainers running this suite get two deliberate 5.1 s stalls (about 10 s) that assert wall-clock time, which the |
| 🟡 Nit | .github/workflows/shared.yml:123 |
nit: Maintainers get an adapter CI job whose pytest run does not carry the PEP 597 encoding guard the rest of CI relies |
| 🟡 Nit | examples/transports/mcp_transport_examples/grpc_client.py:3 |
nit: New adapter modules add 'from __future__ import annotations', which the repo's test-quality skill says not to use i |
| 🟡 Nit | examples/transports/mcp_transport_examples/grpc_server.py:149 |
nit: AGENTS.md asks public APIs to list catchable exceptions in a 'Raises:' section: 'GRPCServerDispatcher.send_raw_requ |
Loading