Skip to content

Carry capabilities.extensions on legacy initialize handshakes - #3776

Merged
Kludex merged 1 commit into
mainfrom
legacy-initialize-extensions
Oct 27, 2026
Merged

Kludex merged 1 commit into
mainfrom
legacy-initialize-extensions

Carry `capabilities.extensions` on legacy `initialize` handshakes

fe8a1c7
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Oct 27, 2026 in 7m 48s

Code review found 4 potential issues

Found 17 candidates, confirmed 4. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 4
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit src/mcp/server/lowlevel/server.py:560 Legacy clients are now told a server supports an extension whose only methods that server answers with METHOD_NOT_FOUND
🟡 Nit tests/types/test_methods.py:951 nit: The client-request half of the new test passes without this PR, so nothing proves the 'ClientCapabilities' schema p
🟡 Nit tests/types/test_methods.py:938 nit: the new test 'test_initialize_round_trips_capability_extensions_at_pre_2026_versions' has no return type hint, whic
🟡 Nit tests/types/test_methods.py:938 nit: The new parametrized test has no docstring, so a later failure gives no hint whether it is a spec regression or an

Optional notes from this repository's REVIEW.md or CLAUDE.md checks, not posted as comments

File:Line Note
src/mcp/server/lowlevel/server.py:560 nit: AGENTS.md treats any change to an existing v2 API's observable behaviour as an explicit…