Repository navigation
Conversation
Signed-off-by: bbdu3 <ergouyang854@gmail.com>
|
This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3854. If a maintainer assigns you to #3854, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take. You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way. CONTRIBUTING.md has the full reasoning, but in short:
Maintainers: reopen, remove |
summary
Remove five unused variables across the codebase
Fixes #3854.
Clean up dead code left behind from previous refactoring PRs:
stdio.py: Remove
_StreamClaim.fdfield (PR Isolate the stdio server's stdin and stdout from handler subprocesses #3117). The field wasstored but never read; only
private_fdis actually used.server/main.py: Remove
logger(PR [v2] Dispatcher/ServerRunner receive-path swap — replaces BaseSession #2710). Thereceive_loop()function that used it was removed.
simple-streamablehttp-stateless/server.py: Remove
logger(PR refactor(examples): migrate all HTTP examples to streamable_http_app() #2291).The lifespan implementation with logging calls was removed.
simple-auth/server.py: Remove
app._resource_server_settings(PR refactor: move transport-specific parameters from FastMCP constructor to run() #1898).Despite the comment, it's never read;
run()receives params directly.simple-auth/legacy_as_server.py: Remove
app._server_settings.Same pattern; params passed directly to
run().No functional changes. All tests pass.